Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FID and IID when working with sample IDs #17

Merged
merged 10 commits into from
Jul 22, 2024
Merged

Use FID and IID when working with sample IDs #17

merged 10 commits into from
Jul 22, 2024

Conversation

nebfield
Copy link
Member

@nebfield nebfield commented Jul 16, 2024

PGScatalog/pgsc_calc#234
PGScatalog/pgsc_calc#325
PGScatalog/pgsc_calc#238

Samples with duplicated IIDs caused problems, even if FIDs were different

@nebfield nebfield changed the title Fix handling IID / FID duplicates Use FID and IID when working with sample IDs Jul 16, 2024
@nebfield nebfield requested a review from smlmbrt July 16, 2024 15:36
src/fraposa_pgsc/fraposa.py Outdated Show resolved Hide resolved
@nebfield nebfield requested a review from smlmbrt July 19, 2024 15:10
Copy link
Member

@smlmbrt smlmbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine now

@nebfield nebfield merged commit 6c62aa5 into master Jul 22, 2024
1 check passed
@nebfield nebfield deleted the fix-fid branch July 22, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants