Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the removal of variants Y location to all that have existing X… #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extend the removal of variants Y location to all that have existing X… #7

wants to merge 1 commit into from

Conversation

ens-lgil
Copy link
Member

@ens-lgil ens-lgil commented Nov 1, 2023

… location, even if the chr position is different

@ens-lgil
Extend the removal of variants Y location to all that have existing X…
b352416 
… location, even if the chr position is different
@ens-lgil ens-lgil requested a review from smlmbrt November 1, 2023 10:06
smlmbrt
smlmbrt reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@smlmbrt smlmbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would making the current_varname a PRIMARY KEY in the locations table also help ensure we don't have multi-mapping?

@ens-lgil
Copy link
Member Author

ens-lgil commented Nov 1, 2023

Yes, that could do it.
However we will need to manage the "duplicates" before the update of the KB.

Just looking at the KB, I see that we have duplicates for:

  • X/Y mappings
  • Variant insertion, e.g.:
    rs80280902|11|100476356|100476356|-/G
    rs80280902|11|100476357|100476356|-/G

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlmbrt smlmbrt smlmbrt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ens-lgil @smlmbrt