Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parameter trait_efo to efo_id #263

Closed
smlmbrt opened this issue Mar 19, 2024 · 1 comment
Closed

Change parameter trait_efo to efo_id #263

smlmbrt opened this issue Mar 19, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
v2.0.0-beta.2

Comments

@smlmbrt
Copy link
Member

smlmbrt commented Mar 19, 2024

Description of feature

It's confusing that the other inputs for score download are pgs_id and pgp_id but the traits are called trait_efo. Suggest we change this to efo_id or at least have that as an alias.
@smlmbrt smlmbrt added the enhancement New feature or request label Mar 19, 2024
@nebfield nebfield added this to the v2.0.0-alpha.6 milestone Apr 16, 2024
@nebfield nebfield modified the milestones: v2.0.0-beta.1, v2.0.0-beta.2 Jul 8, 2024
@nebfield
Copy link
Member

Now available in v2.0.0-beta.2 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0-beta.2
Development

No branches or pull requests
2 participants
@smlmbrt @nebfield