Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename r.abin to run.abin.sh #191

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Rename r.abin to run.abin.sh #191

merged 2 commits into from
Jan 6, 2025

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Nov 27, 2024

I would like to rename r.abin and similar scripts, since the name can be a bit weird to newcommers. For now I decided for run.abin.sh, but I would love to hear feedback on the naming!

Closes #146.
Closes #196

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (5e79a24) to head (361377c).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   92.76%   92.84%   +0.07%     
==========================================
  Files          47       47              
  Lines        6693     6760      +67     
  Branches      757      764       +7     
==========================================
+ Hits         6209     6276      +67     
  Misses        472      472              
  Partials       12       12              
Flag Coverage Δ
unittests 20.37% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@JanosJiri JanosJiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming r.abin seems like a good idea. I would maybe use run.terachem_mpi_abin.sh instead of run.tc_mpi_abin.sh. Not everyone will know that tc means terachem.

@danielhollas
Copy link
Contributor Author

I would maybe use run.terachem_mpi_abin.sh instead of run.tc_mpi_abin.sh. Not everyone will know that tc means terachem.

Agreed, I've renamed them based on your suggestion. I've also resolved issues reported in #196

@danielhollas danielhollas mentioned this pull request Dec 12, 2024
@danielhollas danielhollas merged commit d703fb0 into master Jan 6, 2025
17 checks passed
@danielhollas danielhollas deleted the rename-run-abin branch January 6, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor bug in r.abin Rename r.abin* scripts
2 participants