Velocity and geometry units added to output files. #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The units of geometries and velocities are lacking in their respective output files. I've spent time looking for the right units of velocities in ABIN several times (because I always forget) and others in Prague have the same issue. I suggest to add the units of geometries and especially velocities to their respective output files.
The proposed way adds the units to every single geometry/velocity such that if someone greps specific geometries/velocities, the information about the unit is kept. Alternatively, the unit could be added to a header, but this would add one extra line and could break loads of existing scripts grepping from movie.xyz or velocities.xyz. What I propose is left for discussion @danielhollas , but adding this would save a lot of time for many people.
FYI, all the tests are failing because of the added units to the files but I did not mend the tests before (or if) we agree on the precise way of adding them.