Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support Header elements within Title elements #2674

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SpraxDev
Copy link
Contributor

@SpraxDev SpraxDev commented Sep 12, 2024

Description

We encountered issues with a Word document where this is a valid combination.
This fixes parsing the document properly.

Fixes # (issue) No open issue found (but similar to #2616)

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes Does not apply
  • I have updated the changelog

@SpraxDev
Copy link
Contributor Author

SpraxDev commented Sep 12, 2024

Is a test case needed for this kind of change?
Do you have a recommendation on where to put it?

@coveralls
Copy link

coveralls commented Sep 12, 2024

Coverage Status

coverage: 96.918%. remained the same
when pulling 4c7aaeb on SpraxDev:fix/support-header-within-title
into f0ec497 on PHPOffice:master.

@SpraxDev SpraxDev marked this pull request as ready for review September 12, 2024 16:57
@SpraxDev SpraxDev force-pushed the fix/support-header-within-title branch from 03b8816 to 1a1db6c Compare September 13, 2024 09:04
@SpraxDev SpraxDev force-pushed the fix/support-header-within-title branch from 1a1db6c to 4c7aaeb Compare September 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants