Merge pull request #5 from srjlewis/master

Fix for expiry ttl, as couchbase >= v4, now can use DateTimeInterface for the ttl
PHPSocialNetwork · Jun 14, 2024 · 2c93fa3 · 2c93fa3
2 parents c445d4e + bd11a22
commit 2c93fa3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/Phpfastcache/Extensions/Drivers/Couchbasev4/Driver.php b/lib/Phpfastcache/Extensions/Drivers/Couchbasev4/Driver.php
@@ -263,7 +263,7 @@ protected function driverWrite(ExtendedCacheItemInterface $item): bool
             $this->getCollection()->upsert(
                 $item->getEncodedKey(),
                 $this->encodeDocument($this->driverPreWrap($item)),
-                (new UpsertOptions())->expiry($item->getTtl())
+                (new UpsertOptions())->expiry($item->getExpirationDate())
             );
             return true;
         } catch (CouchbaseException) {

diff --git a/tests/Couchbasev4.test.php b/tests/Couchbasev4.test.php
@@ -70,6 +70,15 @@
 $cache1->set('forkSuccessTestKey1', $value1);
 $cache2->set('forkSuccessTestKey2', $value2);
 
+// 1576800000 is the int limit within Couchbase for the ttl before the need to use DateTime
+// so using an int like '\time() + 3600' would produce an error, to reproduce the error
+// within phpFastCache we need to push the date 1576800001s in the future to overflow the ttl int
+if($cache->set('bigTTL', 'test', new DateInterval('PT1576800001S'))) {
+    $testHelper->assertPass('Set with large ttl succeeded');
+} else {
+    $testHelper->assertFail('Set with large ttl failed');
+}
+
 try {
     \Phpfastcache\Extensions\Drivers\Couchbasev4\Driver::prepareToFork();
     $pid = \pcntl_fork();