Skip to content

Conversation

@emerali
Copy link
Collaborator

@emerali emerali commented Sep 8, 2020

This won't be merged for a while since PyTorch's complex API isn't stable yet

TODO:

  • Fix KL bug
    • KL divergence seems like it's being computed wrong for the complex cases (DensityMatrix's numerical and algorithmic gradients seem to both be wrong)
    • Add gradient tests which only operate in the reference basis (i.e. dont need to do any grad rotations)
    • In gradient tests, if the gradients for one sub-network are wrong, the other sub-networks aren't tested. Should fix this to test all sub-networks before erroring out (maybe separate tests for each sub-network?)

@emerali emerali added enhancement New feature or request Size: Huge For issues that will take a while to finish Status: In Progress Currently being worked on gpu labels Sep 8, 2020
@emerali emerali self-assigned this Sep 8, 2020
@emerali emerali added the Status: Blocked Require other issues to be resolved first label Sep 8, 2020
@emerali emerali marked this pull request as draft September 8, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request gpu Size: Huge For issues that will take a while to finish Status: Blocked Require other issues to be resolved first Status: In Progress Currently being worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants