Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Transition to PyTorch's complex API #120

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

emerali
Copy link
Collaborator

@emerali emerali commented Sep 8, 2020

This won't be merged for a while since PyTorch's complex API isn't stable yet

TODO:

  • Fix KL bug
    • KL divergence seems like it's being computed wrong for the complex cases (DensityMatrix's numerical and algorithmic gradients seem to both be wrong)
    • Add gradient tests which only operate in the reference basis (i.e. dont need to do any grad rotations)
    • In gradient tests, if the gradients for one sub-network are wrong, the other sub-networks aren't tested. Should fix this to test all sub-networks before erroring out (maybe separate tests for each sub-network?)

@emerali emerali added enhancement New feature or request Size: Huge For issues that will take a while to finish Status: In Progress Currently being worked on gpu labels Sep 8, 2020
@emerali emerali self-assigned this Sep 8, 2020
@emerali emerali added the Status: Blocked Require other issues to be resolved first label Sep 8, 2020
@emerali emerali marked this pull request as draft September 8, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gpu Size: Huge For issues that will take a while to finish Status: Blocked Require other issues to be resolved first Status: In Progress Currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant