v2.0 followup fixup (#378)

* Remove unneeded comment

* Simplify WaleltBalance rendering and naming

* Optimise background switch watcher

Note: not a fan of *adding* back to the global.js doms list, however, I'll take that compromise for a tiny improvement in latency over spamming DOM searches.

* Modularise & remove duplicate Charting code

* Fix JSDoc typo

* Switch Contacts to Shield, fix XPub Contact usage, fix UX issues

* Improve UX of Contacts for unencrypted wallets
Previously there was no indication that Contacts were unusable until post-encryption, this commit hopes to make it more obvious, as well as removing the empty modal popup, and changing opacity to match it's availability.

* Lower Ledger opacity on Firefox
Similar to the last commit, this makes it more obvious that Ledger is unavailable on Firefox.

* Prettier

* Use a lower 'unavailable' Contacts opacity

* Improve USB support detection

* Change i18n key to reflect USB logic changes
Note: the i18n translations themselves need updating to reflect the change as well, it is no longer Firefox-specific, but applies to other Gecko or WebKit browsers too.

* Fix missed translation key update

* Prettier

* Safer analytics key checks

* Fix scanning Contact QRs in the Send UI

* Remove commands from the URL after running

* Force a toggle to be in sync with it's variable

* Add Labs X link to the footer

assets/style/style.css

@@ -3993,7 +3993,11 @@ textarea::placeholder {
     border-radius: 7px;
     border: 1px solid #af9cc6;
     padding: 7px 10px;
-    display:block;
+    display: block;
+    /* Allow addresses to nicely cut-off to encourage Clipboard usage */
+    text-overflow: ellipsis;
+    white-space: nowrap;
+    overflow: hidden;
 }
 
 .mnTopConfigured {

index.template.html

@@ -622,7 +622,7 @@ <h2 id="mnLastSeen" class="stake-balances" style="overflow-wrap: anywhere; top:
         <div class="footer">
           <div>
             <span> © MIT <span id="copyrightYear">2024</span> </span> - <span style="cursor: pointer;" onclick="MPW.playMusic()" data-i18n="footerBuiltWithPivxLabs">Built with 💜 by PIVX Labs</span><br />
-            <a href="https://github.com/PIVX-Labs/MyPIVXWallet" target="_blank" rel="noopener noreferrer"><i class="fa-brands fa-github"></i></i></a> - <a href="https://discord.gg/zTScGaGtgv" target="_blank" rel="noopener noreferrer"><i class="fa-brands fa-discord"></i></i></a> - <a href="https://medium.com/@pivx-labs" target="_blank" rel="noopener noreferrer"><i class="fa-brands fa-medium"></i></i></a> - <span id="version" class="ptr" onclick="MPW.renderChangelog();"></span>
+            <a href="https://github.com/PIVX-Labs/MyPIVXWallet" target="_blank" rel="noopener noreferrer"><i class="fa-brands fa-github"></i></i></a> - <a href="https://discord.gg/zTScGaGtgv" target="_blank" rel="noopener noreferrer"><i class="fa-brands fa-discord"></i></i></a> - <a href="https://medium.com/@pivx-labs" target="_blank" rel="noopener noreferrer"><i class="fa-brands fa-medium"></i></i></a> - <a href="https://x.com/PIVX_Labs" target="_blank" rel="noopener noreferrer"><i class="fa-brands fa-x-twitter"></i></i></a> - <span id="version" class="ptr" onclick="MPW.renderChangelog();"></span>
           </div>
         </div>
       </footer>

locale/cnr/translation.toml

@@ -306,7 +306,7 @@ SWITCHED_SYNC = "<b>Promijenili ste režim sinhronizacije!</b><br>Sada koristite
 UNABLE_SWITCH_TESTNET = "<b>Nemoguća je promijena režima testne mreže!</b><br>Novčanik je već učitan" # <b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded
 WALLET_OFFLINE_AUTOMATIC = "<b>Režim van mreže je aktivan!</b><br>Molimo onemogućite režim van mreže za automatske transakcije" # <b>Offline Mode is active!</b><br>Please disable Offline Mode for automatic transactions
 WALLET_UNLOCK_IMPORT = "Molimo {unlock} vaš novčanik pre slanja transakcija!" # Please {unlock} your wallet before sending transactions!
-WALLET_FIREFOX_UNSUPPORTED = "<b>Firefox ovo ne podržava!</b><br>Nažalost, Firefox ne podržava hardverske novčanike" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
+WALLET_HARDWARE_USB_UNSUPPORTED = "<b>Firefox ovo ne podržava!</b><br>Nažalost, Firefox ne podržava hardverske novčanike" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 WALLET_HARDWARE_WALLET = "<b>Hardverski novčanik je spreman!</b><br>Molimo vas da držite svoj {hardwareWallet} priključen, otključan i u aplikaciji PIVX" # <b>Hardware wallet ready!</b><br>Please keep your {hardwareWallet} plugged in, unlocked, and in the PIVX app
 WALLET_CONFIRM_L = "Potvrdite uvoz na vašem Ledger-u" # Confirm the import on your Ledger
 WALLET_NO_HARDWARE = "<b>Nema dostupnog uređaja</b><br>Nije moguće pronaći hardverski novčanik; molimo vas da ga priključite i otključate!" # <b>No device available</b><br>Couldn't find a hardware wallet; please plug it in and unlock!

locale/de/translation.toml

@@ -306,7 +306,7 @@ SWITCHED_SYNC = "<b>Modus zum Abgleich geändert!</b><br>Aktuell: {sync} Abgleic
 UNABLE_SWITCH_TESTNET = "<b>Ein wechsel in den Testnet Modus ist unmöglich!</b><br>Es ist bereits eine Geldbörse geladen" # <b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded
 WALLET_OFFLINE_AUTOMATIC = "<b>Der offline Modus ist aktiv!</b><br>Bitte deaktivere den offline Modus für automatische Transaktionen" # <b>Offline Mode is active!</b><br>Please disable Offline Mode for automatic transactions
 WALLET_UNLOCK_IMPORT = "Bitte {unlock} deine Geldbörse bevor du Transaktionen tätigst!" # Please {unlock} your wallet before sending transactions!
-WALLET_FIREFOX_UNSUPPORTED = "<b>Firefox unterstütz diese Funktion nicht!</b><br>Leider unterstützt Firefox keine Hardware-Geldbörsen" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
+WALLET_HARDWARE_USB_UNSUPPORTED = "<b>Firefox unterstütz diese Funktion nicht!</b><br>Leider unterstützt Firefox keine Hardware-Geldbörsen" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 WALLET_HARDWARE_WALLET = "<b>Hardware-Geldbörse bereit!</b><br>Bitte lass dein {hardwareWallet} eingesteckt, entsperrt und in der PIVX app aktiviert" # <b>Hardware wallet ready!</b><br>Please keep your {hardwareWallet} plugged in, unlocked, and in the PIVX app
 WALLET_CONFIRM_L = "Bestätige den Import auf deinem Ledger" # Confirm the import on your Ledger
 WALLET_NO_HARDWARE = "<b>Kein Gerät verfügbar</b><br>Es wurde keine Hardware-Geldbörse gefunden, bitte stecke es ein und entsperre es!" # <b>No device available</b><br>Couldn't find a hardware wallet; please plug it in and unlock!

locale/en/translation.toml

@@ -306,7 +306,7 @@ SWITCHED_SYNC = "<b>Switched sync mode!</b><br>Now using {sync} sync" # <b>Switc
 UNABLE_SWITCH_TESTNET = "<b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded" # <b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded
 WALLET_OFFLINE_AUTOMATIC = "<b>Offline Mode is active!</b><br>Please disable Offline Mode for automatic transactions" # <b>Offline Mode is active!</b><br>Please disable Offline Mode for automatic transactions
 WALLET_UNLOCK_IMPORT = "Please {unlock} your wallet before sending transactions!" # Please {unlock} your wallet before sending transactions!
-WALLET_FIREFOX_UNSUPPORTED = "<b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
+WALLET_HARDWARE_USB_UNSUPPORTED = "<b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 WALLET_HARDWARE_WALLET = "<b>Hardware wallet ready!</b><br>Please keep your {hardwareWallet} plugged in, unlocked, and in the PIVX app" # <b>Hardware wallet ready!</b><br>Please keep your {hardwareWallet} plugged in, unlocked, and in the PIVX app
 WALLET_CONFIRM_L = "Confirm the import on your Ledger" # Confirm the import on your Ledger
 WALLET_NO_HARDWARE = "<b>No device available</b><br>Couldn't find a hardware wallet; please plug it in and unlock!" # <b>No device available</b><br>Couldn't find a hardware wallet; please plug it in and unlock!

locale/es-mx/translation.toml

@@ -294,7 +294,7 @@ SWITCHED_SYNC = "<b>¡El Modo de sincronización a cambiado!</b><br>Ahora se usa
 UNABLE_SWITCH_TESTNET = "<b>¡No se puede cambiar a modo Testnet!</b><br>Ya hay una wallet cargada" # <b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded
 WALLET_OFFLINE_AUTOMATIC = "<b>¡El modo sin conexión está activo!</b><br>Desactiva el modo sin conexión para transacciones automáticas" # <b>Offline Mode is active!</b><br>Please disable Offline Mode for automatic transactions
 WALLET_UNLOCK_IMPORT = "¡Por favor {unlock} tu wallet antes de enviar transacciones!" # Please {unlock} your wallet before sending transactions!
-WALLET_FIREFOX_UNSUPPORTED = "<b>¡Firefox no admite esto!</b><br>Desafortunadamente, Firefox no admite wallets de hardware" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
+WALLET_HARDWARE_USB_UNSUPPORTED = "<b>¡Firefox no admite esto!</b><br>Desafortunadamente, Firefox no admite wallets de hardware" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 WALLET_HARDWARE_WALLET = "<b>¡Listo para la wallet de hardware!</b><br>Manten tu {hardwareWallet} conectada, desbloqueada y en la aplicación PIVX." # <b>Hardware wallet ready!</b><br>Please keep your {hardwareWallet} plugged in, unlocked, and in the PIVX app
 WALLET_CONFIRM_L = "Confirma la importación en tu Ledger" # Confirm the import on your Ledger
 WALLET_NO_HARDWARE = "<b>No hay ningún dispositivo disponible</b><br>No se pudo encontrar una wallet de hardware; ¡Conéctala y desbloquéala!" # <b>No device available</b><br>Couldn't find a hardware wallet; please plug it in and unlock!

locale/fr/translation.toml

@@ -294,7 +294,7 @@ SWITCHED_SYNC = "<b>Changement de mode de synchronisation !</b><br>Utiliser la s
 UNABLE_SWITCH_TESTNET = "<b>Il n'est pas possible de passer en mode Testnet !</b><br>Un portefeuille est déjà chargé." # <b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded
 WALLET_OFFLINE_AUTOMATIC = "<b>Le mode hors-ligne est actif !</b><br>Veuillez désactiver le mode hors connexion pour les transactions automatiques" # <b>Offline Mode is active!</b><br>Please disable Offline Mode for automatic transactions
 WALLET_UNLOCK_IMPORT = "S'il vous plaît, {unlock} votre portefeuille avant d'envoyer des transactions !" # Please {unlock} your wallet before sending transactions!
-WALLET_FIREFOX_UNSUPPORTED = "<b>O Firefox ne supporte pas cela !</b><br>Malheureusement, Firefox ne prend pas en charge les portefeuilles hardware" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
+WALLET_HARDWARE_USB_UNSUPPORTED = "<b>O Firefox ne supporte pas cela !</b><br>Malheureusement, Firefox ne prend pas en charge les portefeuilles hardware" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 WALLET_HARDWARE_WALLET = "<b>Portefeuille de Hardware prêt!</b><br>Gardez votre {hardwareWallet} connecté, déverrouillé et dans l'application PIVX" # <b>Hardware wallet ready!</b><br>Please keep your {hardwareWallet} plugged in, unlocked, and in the PIVX app
 WALLET_CONFIRM_L = "Confirmez l'importation dans votre Ledger" # Confirm the import on your Ledger
 WALLET_NO_HARDWARE = "<b>Aucun dispositif disponible</b><br>Il n'a pas été possible de trouver un portefeuille de hardware; brancher et déverrouiller!" # <b>No device available</b><br>Couldn't find a hardware wallet; please plug it in and unlock!

locale/it/translation.toml

@@ -294,7 +294,7 @@ SWITCHED_SYNC = "<b>Modalità di sincronizzazione cambiata!</b><br>Ora stai util
 UNABLE_SWITCH_TESTNET = "<b>Impossibile cambiare la modalità Testnet!</b><br>Un wallet è già caricato" # <b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded
 WALLET_OFFLINE_AUTOMATIC = "<b>La modalità offline è attiva!</b><br>Disattiva la modalità offline per le transazioni automatiche" # <b>Offline Mode is active!</b><br>Please disable Offline Mode for automatic transactions
 WALLET_UNLOCK_IMPORT = "Per favore, {unlock} il tuo wallet prima di compiere transazioni di invio!" # Please {unlock} your wallet before sending transactions!
-WALLET_FIREFOX_UNSUPPORTED = "<b>Firefox non lo supporta!</b><br>, Firefox sfortunatamnete non supporta portafogli hardware " # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
+WALLET_HARDWARE_USB_UNSUPPORTED = "<b>Firefox non lo supporta!</b><br>, Firefox sfortunatamnete non supporta portafogli hardware " # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 WALLET_HARDWARE_WALLET = "<b>Wallet hardware pronto!</b><br>Tieni il tuo {hardwareWallet} collegato, sbloccato e nell'app PIVX" # <b>Hardware wallet ready!</b><br>Please keep your {hardwareWallet} plugged in, unlocked, and in the PIVX app
 WALLET_CONFIRM_L = "Conferma l'importo sulla tua Ledger" # Confirm the import on your Ledger
 WALLET_NO_HARDWARE = "<b>Nessun dispositivo disponibile</b><br>Impossibile trovare un wallet hardware; per favore collegalo e sbloccalo!" # <b>No device available</b><br>Couldn't find a hardware wallet; please plug it in and unlock!

locale/nl/translation.toml

@@ -306,7 +306,7 @@ SWITCHED_SYNC = "<b>Synchronisatiemodus gewisseld!</b><br>Gebruikt nu {sync} syn
 UNABLE_SWITCH_TESTNET = "<b>Kan de Testnet-modus niet inschakelen!</b><br>Een portemonnee is al geladen" # <b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded
 WALLET_OFFLINE_AUTOMATIC = "<b>Offline modus is actief!</b><br>Schakel Offline modus uit voor automatische transacties" # <b>Offline Mode is active!</b><br>Please disable Offline Mode for automatic transactions
 WALLET_UNLOCK_IMPORT = "Ontgrendel je portemonnee {unlock} voordat je transacties verstuurt!" # Please {unlock} your wallet before sending transactions!
-WALLET_FIREFOX_UNSUPPORTED = "<b>Firefox ondersteunt dit niet!</b><br>Helaas ondersteunt Firefox geen hardware wallets" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
+WALLET_HARDWARE_USB_UNSUPPORTED = "<b>Firefox ondersteunt dit niet!</b><br>Helaas ondersteunt Firefox geen hardware wallets" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 WALLET_HARDWARE_WALLET = "<b>Hardware wallet klaar!</b><br>Houd je {hardwareWallet} aangesloten, ontgrendeld en in de PIVX-app" # <b>Hardware wallet ready!</b><br>Please keep your {hardwareWallet} plugged in, unlocked, and in the PIVX app
 WALLET_CONFIRM_L = "Bevestig de import op je Ledger" # Confirm the import on your Ledger
 WALLET_NO_HARDWARE = "<b>Geen apparaat beschikbaar</b><br>Kon geen hardware wallet vinden; sluit deze aan en ontgrendel!" # <b>No device available</b><br>Couldn't find a hardware wallet; please plug it in and unlock!

locale/ph/translation.toml

@@ -293,7 +293,7 @@ SWITCHED_SYNC = "<b>Nagpalit ng sync mode!</b><br>Ang gamit ngayon ay {sync} syn
 UNABLE_SWITCH_TESTNET = "Hindi makapag palit sa Testnet Mode!</b><br> Nakapag load na ang wallet" # <b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded
 WALLET_OFFLINE_AUTOMATIC = "<b>Aktibo ang Offline Mode!</b><br>Pakiusap wag paganahin ang Offline Mode para sa automatikong transaksyon" # <b>Offline Mode is active!</b><br>Please disable Offline Mode for automatic transactions
 WALLET_UNLOCK_IMPORT = "Pakiusap {unlock} ang iyong wallet bago magpadala ng transaksyon!" # Please {unlock} your wallet before sending transactions!
-WALLET_FIREFOX_UNSUPPORTED = "<b> Hindi ito supportado ng Firefox!</b><br>Sa kasamaang palad, hindi supportado ng Firefox ang mga hardware wallet" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
+WALLET_HARDWARE_USB_UNSUPPORTED = "<b> Hindi ito supportado ng Firefox!</b><br>Sa kasamaang palad, hindi supportado ng Firefox ang mga hardware wallet" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 WALLET_HARDWARE_WALLET = "<b>Handa na ang Hardware wallet!</b><br>Pakiusap panatilihin mo na ang {hardwareWallet} ay naka plugged in, naka bukas, at nasa PIVX app " # <b>Hardware wallet ready!</b><br>Please keep your {hardwareWallet} plugged in, unlocked, and in the PIVX app
 WALLET_CONFIRM_L = "Kumpirmahin ang import sa iyong Ledger" # Confirm the import on your Ledger
 WALLET_NO_HARDWARE = "<b>Walang pwedeng magamit na device</b><br>Hindi makahanap ng hardware wallet; pakiusap i-plug in ito at buksan!" # <b>No device available</b><br>Couldn't find a hardware wallet; please plug it in and unlock!

locale/pl/translation.toml

@@ -306,7 +306,7 @@ SWITCHED_SYNC = "<b>Przełączono tryb synchronizacji! </b><br>NTeraz używana j
 UNABLE_SWITCH_TESTNET = "<b>Nie można przełączyć trybu Testnet!</b><br>portfel jest już załadowany" # <b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded
 WALLET_OFFLINE_AUTOMATIC = "<b>Tryb offline jest aktywny!</b><br>Wyłącz tryb Offline dla automatycznych transakcji" # <b>Offline Mode is active!</b><br>Please disable Offline Mode for automatic transactions
 WALLET_UNLOCK_IMPORT = "Proszę {unlock} swój portfel przed wysłaniem transakcji!" # Please {unlock} your wallet before sending transactions!
-WALLET_FIREFOX_UNSUPPORTED = "<b>Firefox nie obsługuje tego!</b><br>Niestety, Firefox nie obsługuje portfeli sprzętowych." # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
+WALLET_HARDWARE_USB_UNSUPPORTED = "<b>Firefox nie obsługuje tego!</b><br>Niestety, Firefox nie obsługuje portfeli sprzętowych." # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 WALLET_HARDWARE_WALLET = "<b>Portfel sprzętowy (Hardware Waller) gotowy!</b><br>Portfel {hardwareWallet} powinien być podłączony, odblokowany i znajdować się w aplikacji PIVX." # <b>Hardware wallet ready!</b><br>Please keep your {hardwareWallet} plugged in, unlocked, and in the PIVX app
 WALLET_CONFIRM_L = "Potwierdź import na swoim Ledgerze." # Confirm the import on your Ledger
 WALLET_NO_HARDWARE = "<b>Brak dostępnego urządzenia</b><br>Nie można znaleźć portfela sprzętowego; podłącz go i odblokuj!" # <b>No device available</b><br>Couldn't find a hardware wallet; please plug it in and unlock!

locale/pt-br/translation.toml

@@ -116,7 +116,7 @@ SWITCHED_EXPLORERS = "<b>Explorador trocado!</b><br>Agora será utilizado o {exp
 SWITCHED_NODE = "<b>Nó trocado!</b><br>Agora será utilizado o {node}" # <b>Switched node!</b><br>Now using {node}
 SWITCHED_SYNC = "<b>Modo de sincronização alternado!</b><br>Agora sera utilizada a sincronização {sync}" # <b>Switched sync mode!</b><br>Now using {sync} sync
 UNABLE_SWITCH_TESTNET = "<b>Não é possível alternar o modo Testnet!</b><br>Uma carteira está aberta." # <b>Unable to switch Testnet Mode!</b><br>A wallet is already loaded
-WALLET_FIREFOX_UNSUPPORTED = "<b>O Firefox não tem suporte para isto!</b><br>Infelizmente, o Firefox não suporta carteiras de hardware" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
+WALLET_HARDWARE_USB_UNSUPPORTED = "<b>O Firefox não tem suporte para isto!</b><br>Infelizmente, o Firefox não suporta carteiras de hardware" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 WALLET_HARDWARE_UDEV = "<b> O Sistema operacional recusou o acesso </b> Você adicionou as regras de udev?" # <b>The OS denied access</b> Did you add the udev rules?
 WALLET_HARDWARE_NO_ACCESS = "<b> O Sistema operacional recusou o acesso </b> Por favor cheque as configurações do seu sistema operacional" # <b>The OS denied access</b> Please check your Operating System settings.
 WALLET_HARDWARE_CONNECTION_LOST = "<b>Conexão perdida com a {hardwareWallet} </b><br>Oops! Parece que a {hardwareWalletProductionName} foi desconectada no meio da operação." # <b>Lost connection to {hardwareWallet} </b><br>It seems the {hardwareWallet} was unplugged mid-operation, oops!