Masternode list fix and rewards #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Minimize Fix rewards size
|
Closing as stale, feel free to reopen it or make a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #97
I had issues with rebasing so took a slow period to bring it in line with other changes between review.
Abstract
This PR is the start of adding a "Last Paid" section for the Masternode tab. It will also attempt to calculate when the next incoming reward is for the user. Math is fairly straightforward as we calculate the MN count and convert the last paid into minutes vs the next amount of time it should be rewarded. There is a masternode reward list which is mainly a clone of the staking list with changes that should read the masternode reward output. This understandably can still be broken, but have been struggling to test with masternodes to open this further to the group to get it moving forward.
What does this PR address?
This PR helps users get more information about their masternode in the Masternode tab. Alongside this takes care of 2/3 from Issue #61 #61
What features or improvements were added?
Users now have their last paid time calculated and can get a roundabout time frame for the next payment.
How does this benefit users?
More data == more power baby!
We need users to be empowered to have the information everyone feels they need inside MPW.