-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tsc lint #130
Add Tsc lint #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I encountered that bug in #121 but forgot about it. If we look at the code (in master) we are importing the wallet first and loading the network after that, it only worked because the wallet code was async and the settings code wasn't (and we weren't awaiting), since the scheduler waits for the tick to finish it would execute after the network and work. This is the reason I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK e0fb36d, working now - no errors, the extra hardened typing will certainly help prevent many future MPW bugs, great job!! 💜 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 27cf487
Went through this a few times! I did not really encounter any issue gg LGTM
Closing as stale |
Abstract
Add typescript linting. It takes type information from jsdoc comments, or is able to deduce it itself
For instance:
Will automatically mark the function as
test(hi: any): number
.Added
@typescript-eslint/no-floating-promises
, the lint will now catch non awaited promises. If the behavior is intentional,.then(()=>{})
can be used.