Governance UI Improvements #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And other minor tweaks like changing "Title" to "Name" and fixing missing translation templating.
JSKitty
added
Bug
|
This PR (and consecutive August PRs) will be merged without reviews. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR introduces a new 'Congrats' popup upon finalising a proposal, with the Vote Hash included (which was previously missing, meaning this PR resolves #167).
It also renames "Title" to "Name" in the proposal creation process, to reduce any confusion from escaping PIVX's older conventions and terminology, resolving #166 too.
And lastly, as suggested by designer YuurinBee, this PR adds a bunch of UI enhancements to the Proposals list, such as: status colour-coding, vertical centre cell alignment, proposal receiver address along with larger White title, and light colour changes.
What does this PR address?
It fixes a UX issue where the Vote Hash was unobtainable, it makes the proposal submitter feel awesome with a friendly 'Congratulations' dialog and a mini DAO help tip, while also correcting some confusing UI elements and naming schemes.
What features or improvements were added?
A new 'Congrats' dialog after finalising a PR, as well as fixing and improving multiple other Governance UI elements.