Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ledger #273

Closed
wants to merge 2 commits into from
Closed

Fix ledger #273

wants to merge 2 commits into from

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Nov 27, 2023

Abstract

Ledger was broken due to it being classified as a 'view only key' despite it having spending authority.
This is considered a temporary fix until #270 is implemented.

Fixed bugs:


Testing

  • Test that you can make ledger TXs
  • Test that lock/unlock dialogs are not visible

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 280529d
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6581b08da0fe5400086c2d49
😎 Deploy Preview https://deploy-preview-273--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Duddino
Copy link
Member Author

Duddino commented Jan 23, 2024

This bug is fixed in the master branch

@Duddino Duddino closed this Jan 23, 2024
@Duddino Duddino deleted the ledger_fix branch January 23, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant