switch to websockets #358
Open
switch to websockets #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JSKitty
added
Awaiting Review
Duddino
reviewed
May 14, 2024
| @@ -107,20 +107,159 @@ export class Network { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * | |||
| */ | |||
| export class ExplorerNetwork extends Network { | |||
There was a problem hiding this comment.
I think we should keep both classes, for explorers that may not support websockets, or just to give the option to users
Duddino
requested changes
Jul 31, 2024
Comment on lines
+194
to
+204
| async awaitWebSocketStatus(status, errMessage) { | ||
| for (let i = 0; i < 100; i++) { | ||
| if (this.ws.readyState === status) { | ||
| break; | ||
| } | ||
| await sleep(100); | ||
| } | ||
| if (this.ws.readyState !== status) { | ||
| throw new Error(errMessage); | ||
| } | ||
| } |
Comment on lines
+247
to
+286
| async sendAndWaitForAnswer(method, params) { | ||
| let attempt = 1; | ||
| const maxAttempts = 10; | ||
| // milliseconds | ||
| const maxAwaitTime = 600 * 1000; | ||
| const frequency = 100; | ||
| while (attempt <= maxAttempts) { | ||
| let receivedInvalidAnswer = false; | ||
| const [id, ws_that_sent] = await this.send(method, params); | ||
| for (let i = 0; i < Math.floor(maxAwaitTime / frequency); i++) { | ||
| const res = this.cachedResults[id]; | ||
| if (res !== undefined) { | ||
| delete this.cachedResults[id]; | ||
| if (res.error) { | ||
| await sleep(1000); | ||
| receivedInvalidAnswer = true; | ||
| break; | ||
| } | ||
| return res; | ||
| } | ||
| await sleep(frequency); | ||
| // If connection got closed while sending do not wait until timeout | ||
| if (ws_that_sent !== this.ws) { | ||
| break; | ||
| } | ||
| } | ||
| debugWarn( | ||
| DebugTopics.NET, | ||
| 'Failed send attempt for ' + method, | ||
| 'attempt ' + | ||
| attempt + | ||
| '/' + | ||
| maxAttempts + | ||
| ' received an invalid answer: ' + | ||
| receivedInvalidAnswer | ||
| ); | ||
| attempt += 1; | ||
| } | ||
| throw new Error('Failed to communicate with the explorer'); | ||
| } |
There was a problem hiding this comment.
Instead of making heavy use of sleep, this should use some form of observer/event and be refactored in another class
| let attempt = 1; | ||
| const maxAttempts = 10; | ||
| // milliseconds | ||
| const maxAwaitTime = 600 * 1000; |
There was a problem hiding this comment.
We shouldn't have a maxAwaitTime, we should only abort if the websocket closes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Replace the legacy HTTP requests based system with a websocket implementation.
Testing
At the moment this is testable only on mainnet (Duddino's testnet explorer needs to be updated still).
What I suggest for testing: