Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Immature balance bug #361

Merged
merged 14 commits into from
May 21, 2024
Merged

Conversation

panleone
Copy link
Member

@panleone panleone commented Apr 29, 2024

Abstract

Changes of this PR

  • The OutpointState IMMATURE has been removed: there is no efficient way to update it. Mempool refactor added it, but did not provide any functions to set it (and indeed MPW isn't currently handling immature balance)
  • Fix balance calculation and getUtxos function (they will not anymore return immature balance/utxos)

@panleone panleone added the Bug This is either a bugfix (PR) or a bug (issue). label Apr 29, 2024
@panleone panleone self-assigned this Apr 29, 2024
@panleone panleone requested review from Duddino and JSKitty and removed request for Duddino April 29, 2024 15:25
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit ce2802b
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6647751bea0f6600082d3cfa
😎 Deploy Preview https://deploy-preview-361--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@panleone
Copy link
Member Author

for the same reason of not having the blockHeight inside the mempool class we also need to move the function getUTXO from mempool to wallet, or we cannot filter immature txs

@panleone panleone marked this pull request as draft April 30, 2024 08:56
@panleone panleone marked this pull request as ready for review May 9, 2024 08:16
@panleone panleone changed the title Move balance handling to wallet Fix Immature balance bug May 17, 2024
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK nice tests

@Duddino Duddino merged commit 718323e into PIVX-Labs:master May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants