Cache and prefetch shield files #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
panleone
previously approved these changes
May 6, 2024
JSKitty
requested changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
When creating or loading a shield wallet, a bunch of helper scripts are fetched from the server sequentially. This happens one time for each thread.
Even though they're cached, a request is still sent to the server to see if the file changed, this creates a noticeable between creating a wallet and getting to the dashboard, particularly on machines with a high number of cores, and/or with a high network latency.
This PR aims to prefetch the required shield files, before they're actually needed. The idea is that by the time someone has created and backed up their seedphrase, the browser would have already fetched the files.
Additionally, this PR adds the util scripts each worker needs in the sapling cache to avoid contacting the server for each worker.
Testing