forked from JSKitty/scc-web3
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto deshield transaction #369
Open
Duddino
wants to merge
9
commits into
PIVX-Labs:master
Choose a base branch
from
Duddino:auto-unburn
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
panleone
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments
Also the name "Auto shield transaction" is not intuitive, users will not understand what it does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR introduces auto deshielding.
Some places like exchanges don't support shield transactions. To circumvent this, MPW is set to automatically deshield to a newly generated address before sending.
Closes #337
Can this transaction be tracked to you?
The burner address is generated using a new change address, which MPW will not reuse. Tools like https://chainz.cryptoid.info/pivx/#!wallets will not work.
However these addresses can be easily tracked if the xpub is known. As of right now the xpub is advertised to explorers, while we only allow a set of trusted explorers, we can't be 100% sure they're not tracking user addresses, although very unlikely. If absolute privacy is needed, as always, it's best to self host an explorer.
We could technically make an address unlinked to the xpub or using a special hardened path, however this makes things more difficult to recover should the first deshield transaction go through and the second one fail.
If this were to happen right now, the deshielded funds would simply be available as regular balance.
Other changes
Shield addresses will now show as red in transfermenu if shield is not enabled
TODO
Testing