Repository navigation
build cleanup: rosdep everything, profiling behind a flag - #7
Merged
Merged
Conversation
fetch content paths are no longer supported in prep for the imminent rko slam binary release (hopefully). at least its on rosdistro now. all packages that rko slam links are now in package.xml, and can be rosdep'd. since rko lio is an upstream dep of this, and handles its dependencies its own way, supporting fetchcontent on both is practically impossible. hence i take the opposite path with rko slam, where rosdep will be the only supported way. you can still clone rko lio into your workspace and do whatever with it, in typical ros fashion. a new version release is made for rko lio, 0.4.1, which is the minimum rko slam will work with from now. utl has no system package, so profiling is opt in now: RKO_SLAM_ENABLE_PROFILING, off by default. off, cmake writes the header utl would have, profiler compiled out, so nothing needs the network.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch content paths are no longer supported in prep for the imminent rko slam binary release (hopefully). at least its on rosdistro now. all packages that rko slam links are now in package.xml, and can be rosdep'd. since rko lio is an upstream dep of this, and handles its dependencies its own way, supporting fetchcontent on both is practically impossible. hence i take the opposite path with rko slam, where rosdep will be the only supported way. you can still clone rko lio into your workspace and do whatever with it, in typical ros fashion.
a new version release is made for rko lio, 0.4.1, which is the minimum rko slam will work with from now.
utl has no system package, so profiling is opt in now and still through fetch content (the only one). RKO_SLAM_ENABLE_PROFILING controls this, off by default. off, cmake writes the header utl would have, profiler compiled out, so nothing needs the network. on, and UTL is fetched and profiling is enabled. can be useful for debugging.