-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add wheel task
, use in CI
#1618
Conversation
run: nox -s tests -f bindings/prql-python/noxfile.py | ||
- run: pip install maturin | ||
- name: Build wheel | ||
run: task build-python-wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wheels have already been built.
prql/.github/workflows/test-python.yaml
Lines 16 to 44 in 8d2a55d
jobs: | |
build-python-wheels: | |
runs-on: ${{ matrix.os }} | |
strategy: | |
fail-fast: false | |
matrix: | |
os: [macos-latest, windows-latest] | |
include: | |
- os: ubuntu-latest | |
target: x86_64 | |
- os: ubuntu-latest | |
target: aarch64 | |
- os: ubuntu-latest | |
target: source | |
steps: | |
- name: 📂 Checkout code | |
uses: actions/checkout@v3 | |
- name: Build wheel | |
uses: ./.github/actions/build-prql-python | |
with: | |
target: ${{ matrix.target }} | |
test: | |
needs: [build-python-wheels] | |
runs-on: ${{ matrix.os }} | |
strategy: | |
fail-fast: false | |
matrix: | |
os: [ubuntu-latest, macos-latest, windows-latest] |
Thanks for reviewing — I should probably either finish this or merge it, sorry for leaving it hanging for so long... |
Note to future self (or if someone else finishes this) — we should add the ability to use CI etc uses |
Most of this was added in a separate PR |
This lets us build & test locally