More OTEL parameters (#15)

PSPDFKit · Jul 29, 2024 · 20c1cfe · 20c1cfe
1 parent 241387c
commit 20c1cfe
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/charts/document-engine/Chart.yaml b/charts/document-engine/Chart.yaml
@@ -3,7 +3,7 @@ name: document-engine
 description: PSPDFKit Document Engine
 icon: data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTAwMCIgaGVpZ2h0PSIxMDAwIiB2aWV3Qm94PSIwIDAgMTAwMCAxMDAwIiBmaWxsPSJub25lIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgo8cGF0aCBkPSJNMzQyLjU2NyA2NTguNjEyTDMyOS40OTYgNjY1LjkxNUwzMzguNzk5IDY1NC4yODZDMzk5LjMxIDU3OS44NDIgNDMzLjAyNiA0ODcuMjExIDQzNC41MjggMzkxLjI4OEw0MzQuNzYgMzc2LjMxTDQ0MC4xMSAzOTAuMjY1QzQ3NC40MDUgNDc5LjkzMiA1MzcuODc4IDU1NS40NDggNjIwLjMxIDYwNC42NTRMNjMzLjE0OCA2MTIuMzI5TDYxOC4zNTYgNjA5Ljk1N0M1MjMuNTcxIDU5NC43NTYgNDI2LjQyOCA2MTEuODk0IDM0Mi41NjcgNjU4LjYxMloiIGZpbGw9IiMxOTBEOTQiLz4KPHBhdGggZD0iTTU1NC41MTkgNTU2LjM2N0M0NzMuMzk2IDQ0Mi4wMzMgNDg3LjMwNCAzNzYuODY1IDUwOS44NjQgMjg5Ljc4OEM1MzYuNjExIDE4Ni41MjQgNDczLjM1IDg0LjA1MDUgMzYyLjU5NyAxMTQuNDI1QzMxMy41MjMgMTI3LjkxNCAyOTYuMTczIDE2MS4zMTIgMjkwLjAzMyAxODQuNzU2QzI1OS45ODQgMjk3Ljc4OSA0MzguMjMxIDQ2Ni4xNzQgNTU0LjUxOSA1NTYuMzY3WiIgZmlsbD0iIzVFNUNFQiIvPgo8cGF0aCBkPSJNMjE3LjEwMyA2NDQuMTg2QzExNC4zMDQgNjcyLjY1NCA1Ny4xODM1IDc3OC43NTUgMTM4Ljg2NSA4NTkuNDEzQzE3NS4wNTMgODk1LjEzNyAyMTIuNjM4IDg5My40NjIgMjM2LjAzNSA4ODcuMzIyQzM0OC45MjggODU2Ljc2MiA0MDUuNjMgNjE4LjE4NCA0MjUuNjMyIDQ3Mi40MDVDMzY3LjE2MiA1OTkuNjI1IDMwMy45OTQgNjIwLjE4NCAyMTcuMTAzIDY0NC4xODZaIiBmaWxsPSIjNUU1Q0VCIi8+CjxwYXRoIGQ9Ik04NzEuNDggNTgyLjY1MUM3ODguNTQzIDUwMC4xNzkgNTUzLjU5NCA1NzAuMzI0IDQxNy4zNSA2MjUuOTFDNTU2Ljg5NiA2MTIuODM5IDYwNi4zODkgNjU3LjQ0OCA2NzAuNTMzIDcyMC41MjJDNzQ2LjU4NiA3OTUuMzE5IDg2Ni45NjggNzkxLjczNyA4OTYuMDQgNjgwLjY1OUM5MDguNjkyIDYzMS40NDUgODg4LjQ1OCA1OTkuNzIyIDg3MS40OCA1ODIuNjUxWiIgZmlsbD0iIzVFNUNFQiIvPgo8L3N2Zz4K
 type: application
-version: 2.8.0
+version: 2.8.1
 appVersion: "1.4.0"
 
 maintainers:

diff --git a/charts/document-engine/templates/config.ConfigMap.yaml b/charts/document-engine/templates/config.ConfigMap.yaml
@@ -87,6 +87,12 @@ data:
 {{-     with .otelPropagators }}
   OTEL_PROPAGATORS: {{ . | quote }}
 {{-     end }}
+{{-     with .otelTracesSampler }}
+  OTEL_TRACES_SAMPLER: {{ . | quote }}
+{{-     end }}
+{{-     with .otelTracesSamplerArg }}
+  OTEL_TRACES_SAMPLER_ARG: {{ . | quote }}
+{{-     end }}
 {{-   else }}
   ENABLE_OPENTELEMETRY: "false"
 {{-   end }}

diff --git a/charts/document-engine/values.yaml b/charts/document-engine/values.yaml
@@ -275,6 +275,7 @@ pspdfkit:
     opentelemetry:
     # Enable OpenTelemetry (`ENABLE_OPENTELEMETRY`), only tracing is currently supported
       enabled: false
+      # https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/
       # `OTEL_EXPORTER_OTLP_ENDPOINT`, if not set, defaults to `http://localhost:4317`
       otlpExporterEndpoint: ""
       # `OTEL_EXPORTER_OTLP_PROTOCOL`, if not set, defaults to `grpc`
@@ -285,6 +286,12 @@ pspdfkit:
       otelResourceAttributes: ""
       # `OTEL_PROPAGATORS`, propagators
       otelPropagators: ""
+      # `OTEL_TRACES_SAMPLER`, should normally not be touched
+      # to allow custom `parent_based` work,
+      # but something like `parentbased_traceidratio` may be considered
+      otelTracesSampler: ""
+      # `OTEL_TRACES_SAMPLER_ARG`, argument for the sampler
+      otelTracesSamplerArg: ""
 
 serviceAccount:
   create: true