Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial schema #27

Merged
merged 7 commits into from
Aug 23, 2024
Merged

Initial schema #27

merged 7 commits into from
Aug 23, 2024

Conversation

lazyoldbear
Copy link
Collaborator

@lazyoldbear lazyoldbear commented Aug 23, 2024 •
edited
Loading

MCLEOD-181

Very initial schema, just to get started.

Works with this, based on magic in values.yaml.

helm plugin install https://github.com/losisin/helm-values-schema-json.git

Then in charts/document-engine/:

helm schema

@lazyoldbear lazyoldbear self-assigned this Aug 23, 2024
@lazyoldbear lazyoldbear requested a review from a team August 23, 2024 00:15
tomassurin
tomassurin approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@tomassurin tomassurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane. I assume you generated the schema from annotations in values?

@lazyoldbear lazyoldbear merged commit 2afcc78 into master Aug 23, 2024
2 checks passed
@lazyoldbear lazyoldbear deleted the ingvarr/2024.8.23-schema branch August 23, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomassurin tomassurin tomassurin approved these changes

Assignees

@lazyoldbear lazyoldbear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazyoldbear @tomassurin