Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle correction #40

Merged
merged 2 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 27 additions & 19 deletions charts/document-engine/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,64 +1,66 @@
# Changelog

- [Changelog](#changelog)
- [3.2.9 (2024-11-15)](#329-2024-11-15)
- [3.2.10 (2024-11-18)](#3210-2024-11-18)
- [Changed](#changed)
- [3.2.9 (2024-11-15)](#329-2024-11-15)
- [Changed](#changed-1)
- [3.2.7 (2024-11-15)](#327-2024-11-15)
- [Added](#added)
- [Changed](#changed-1)
- [Changed](#changed-2)
- [3.2.6 (2024-10-29)](#326-2024-10-29)
- [Added](#added-1)
- [Changed](#changed-2)
- [3.2.5 (2024-10-24)](#325-2024-10-24)
- [Changed](#changed-3)
- [3.2.5 (2024-10-24)](#325-2024-10-24)
- [Changed](#changed-4)
- [3.2.4 (2024-10-17)](#324-2024-10-17)
- [Fixed](#fixed)
- [3.2.3 (2024-10-16)](#323-2024-10-16)
- [Fixed](#fixed-1)
- [3.2.2 (2024-10-09)](#322-2024-10-09)
- [Changed](#changed-4)
- [3.2.1 (2024-09-20)](#321-2024-09-20)
- [Changed](#changed-5)
- [3.2.0 (2024-08-29)](#320-2024-08-29)
- [3.2.1 (2024-09-20)](#321-2024-09-20)
- [Changed](#changed-6)
- [3.1.2 (2024-08-23)](#312-2024-08-23)
- [3.2.0 (2024-08-29)](#320-2024-08-29)
- [Changed](#changed-7)
- [3.1.2 (2024-08-23)](#312-2024-08-23)
- [Changed](#changed-8)
- [3.1.1 (2024-08-23)](#311-2024-08-23)
- [Fixed](#fixed-2)
- [3.1.0 (2024-08-22)](#310-2024-08-22)
- [Added](#added-2)
- [3.0.6 (2024-08-22)](#306-2024-08-22)
- [Changed](#changed-8)
- [Changed](#changed-9)
- [3.0.5 (2024-08-21)](#305-2024-08-21)
- [Fixed](#fixed-3)
- [3.0.4 (2024-08-21)](#304-2024-08-21)
- [Changed](#changed-9)
- [Changed](#changed-10)
- [Added](#added-3)
- [2.9.3 (2024-08-16)](#293-2024-08-16)
- [Fixed](#fixed-4)
- [2.9.2 (2024-08-13)](#292-2024-08-13)
- [Changed](#changed-10)
- [Changed](#changed-11)
- [2.9.1 (2024-08-10)](#291-2024-08-10)
- [Added](#added-4)
- [Changed](#changed-11)
- [Changed](#changed-12)
- [2.9.0 (2024-08-01)](#290-2024-08-01)
- [Added](#added-5)
- [Changed](#changed-12)
- [Changed](#changed-13)
- [Fixed](#fixed-5)
- [2.8.0](#280)
- [Added](#added-6)
- [Changed](#changed-13)
- [Changed](#changed-14)
- [Fixed](#fixed-6)
- [2.7.3](#273)
- [Changed](#changed-14)
- [Changed](#changed-15)
- [Fixed](#fixed-7)
- [2.7.2](#272)
- [Fixed](#fixed-8)
- [2.7.0](#270)
- [Changed](#changed-15)
- [Changed](#changed-16)
- [2.6.2](#262)
- [Added](#added-7)
- [Changed](#changed-16)
- [Changed](#changed-17)
- [2.6.0](#260)
- [Added](#added-8)
- [2.4.0](#240)
Expand All @@ -68,9 +70,15 @@
- [2.2.0](#220)
- [Added](#added-11)
- [2.1.0](#210)
- [Changed](#changed-17)
- [2.0.0](#200)
- [Changed](#changed-18)
- [2.0.0](#200)
- [Changed](#changed-19)

## 3.2.10 (2024-11-18)

### Changed

* Removed earlier added default `lifecycle`: dumb-init makes it unnecessary.

## 3.2.9 (2024-11-15)

Expand Down
2 changes: 1 addition & 1 deletion charts/document-engine/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ type: application
description: Document Engine is a backend software for processing documents and powering automation workflows.
home: https://www.nutrient.io/sdk/document-engine
icon: https://cdn.prod.website-files.com/65fdb7696055f07a05048833/66e58e33c3880ff24aa34027_nutrient-logo.png
version: 3.2.9
version: 3.2.10
appVersion: "1.5.3"

keywords:
Expand Down
34 changes: 17 additions & 17 deletions charts/document-engine/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Document Engine Helm chart

![Version: 3.2.9](https://img.shields.io/badge/Version-3.2.9-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.5.3](https://img.shields.io/badge/AppVersion-1.5.3-informational?style=flat-square)
![Version: 3.2.10](https://img.shields.io/badge/Version-3.2.10-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.5.3](https://img.shields.io/badge/AppVersion-1.5.3-informational?style=flat-square)

Document Engine is a backend software for processing documents and powering automation workflows.

Expand Down Expand Up @@ -320,7 +320,7 @@ The chart depends upon [Bitnami](https://github.com/bitnami/charts/tree/main/bit

| Key | Description | Default |
|-----|-------------|---------|
| [`lifecycle`](./values.yaml#L888) | [Lifecycle](https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/) The defailt value will send SIGTERM to the main Document Engine process upon pod termination. | [...](./values.yaml#L888) |
| [`lifecycle`](./values.yaml#L887) | [Lifecycle](https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/) | `map[]` |
| [`livenessProbe`](./values.yaml#L858) | [Liveness probe](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/) | [...](./values.yaml#L858) |
| [`readinessProbe`](./values.yaml#L871) | [Readiness probe](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/) | [...](./values.yaml#L871) |
| [`startupProbe`](./values.yaml#L845) | [Startup probe](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/) | [...](./values.yaml#L845) |
Expand All @@ -330,31 +330,31 @@ The chart depends upon [Bitnami](https://github.com/bitnami/charts/tree/main/bit

| Key | Description | Default |
|-----|-------------|---------|
| [`affinity`](./values.yaml#L950) | Node affinity | `{}` |
| [`autoscaling`](./values.yaml#L899) | [Autoscaling](https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/) | [...](./values.yaml#L899) |
| [`nodeSelector`](./values.yaml#L947) | [Node selector](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/) | `{}` |
| [`podDisruptionBudget`](./values.yaml#L940) | [Pod disruption budget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) | [...](./values.yaml#L940) |
| [`priorityClassName`](./values.yaml#L959) | [Priority classs](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/) | `""` |
| [`replicaCount`](./values.yaml#L928) | Number of replicas | `1` |
| [`resources`](./values.yaml#L925) | [Resources](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) | `{}` |
| [`schedulerName`](./values.yaml#L962) | [Scheduler](https://kubernetes.io/docs/concepts/scheduling-eviction/kube-scheduler/) | `""` |
| [`tolerations`](./values.yaml#L953) | [Node tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) | `[]` |
| [`topologySpreadConstraints`](./values.yaml#L956) | [Topology spread constraints](https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/) | `[]` |
| [`updateStrategy`](./values.yaml#L931) | [Update strategy](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | `{"rollingUpdate":{},"type":"RollingUpdate"}` |
| [`affinity`](./values.yaml#L943) | Node affinity | `{}` |
| [`autoscaling`](./values.yaml#L892) | [Autoscaling](https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/) | [...](./values.yaml#L892) |
| [`nodeSelector`](./values.yaml#L940) | [Node selector](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/) | `{}` |
| [`podDisruptionBudget`](./values.yaml#L933) | [Pod disruption budget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) | [...](./values.yaml#L933) |
| [`priorityClassName`](./values.yaml#L952) | [Priority classs](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/) | `""` |
| [`replicaCount`](./values.yaml#L921) | Number of replicas | `1` |
| [`resources`](./values.yaml#L918) | [Resources](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) | `{}` |
| [`schedulerName`](./values.yaml#L955) | [Scheduler](https://kubernetes.io/docs/concepts/scheduling-eviction/kube-scheduler/) | `""` |
| [`tolerations`](./values.yaml#L946) | [Node tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) | `[]` |
| [`topologySpreadConstraints`](./values.yaml#L949) | [Topology spread constraints](https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/) | `[]` |
| [`updateStrategy`](./values.yaml#L924) | [Update strategy](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | `{"rollingUpdate":{},"type":"RollingUpdate"}` |

### Chart dependencies

| Key | Description | Default |
|-----|-------------|---------|
| [`minio`](./values.yaml#L989) | [External MinIO chart](https://github.com/bitnami/charts/tree/main/bitnami/minio) | [...](./values.yaml#L989) |
| [`postgresql`](./values.yaml#L967) | [External PostgreSQL database chart](https://github.com/bitnami/charts/tree/main/bitnami/postgresql) | [...](./values.yaml#L967) |
| [`redis`](./values.yaml#L1001) | [External Redis chart](https://github.com/bitnami/charts/tree/main/bitnami/redis) | [...](./values.yaml#L1001) |
| [`minio`](./values.yaml#L982) | [External MinIO chart](https://github.com/bitnami/charts/tree/main/bitnami/minio) | [...](./values.yaml#L982) |
| [`postgresql`](./values.yaml#L960) | [External PostgreSQL database chart](https://github.com/bitnami/charts/tree/main/bitnami/postgresql) | [...](./values.yaml#L960) |
| [`redis`](./values.yaml#L994) | [External Redis chart](https://github.com/bitnami/charts/tree/main/bitnami/redis) | [...](./values.yaml#L994) |

### Other Values

| Key | Description | Default |
|-----|-------------|---------|
| [`revisionHistoryLimit`](./values.yaml#L935) | [Revision history limit](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy) | `10` |
| [`revisionHistoryLimit`](./values.yaml#L928) | [Revision history limit](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy) | `10` |

## Contribution

Expand Down
19 changes: 1 addition & 18 deletions charts/document-engine/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -630,24 +630,7 @@
"type": "array"
},
"lifecycle": {
"properties": {
"preStop": {
"properties": {
"exec": {
"properties": {
"command": {
"items": {
"type": "string"
},
"type": "array"
}
},
"type": "object"
}
},
"type": "object"
}
},
"properties": {},
"type": "object"
},
"livenessProbe": {
Expand Down
9 changes: 1 addition & 8 deletions charts/document-engine/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -882,16 +882,9 @@ readinessProbe:
# @section -- F. Pod lifecycle
terminationGracePeriodSeconds: 30 # @schema type: integer
# -- [Lifecycle](https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/)
# The defailt value will send SIGTERM to the main Document Engine process upon pod termination.
# @section -- F. Pod lifecycle
# @notationType -- reference
lifecycle:
preStop:
exec:
command:
- /bin/sh
- -c
- echo "Terminating container now..." && pkill -e -SIGTERM beam.smp && sleep 10
lifecycle: {}

# -- (object) [Autoscaling](https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/)
# @section -- G. Scheduling
Expand Down