Dev/latency tracking #452
Open
Dev/latency tracking #452
+325
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purg
reviewed
Oct 15, 2024
ros/angel_system_nodes/angel_system_nodes/activity_classification/activity_classifier_tcn.py
Show resolved
Hide resolved
ros/angel_system_nodes/angel_system_nodes/activity_classification/activity_classifier_tcn.py
Show resolved
Hide resolved
ros/angel_system_nodes/angel_system_nodes/latency_tracker/latency_tracker.py
Outdated
Show resolved
Hide resolved
ros/angel_system_nodes/angel_system_nodes/latency_tracker/latency_tracker.py
Outdated
Show resolved
Hide resolved
ros/angel_system_nodes/angel_system_nodes/pose_estimation/pose_estimator.py
Show resolved
Hide resolved
Comment on lines
+296
to
297
| all_poses_msg.header.stamp = self.get_clock().now().to_msg() | ||
| self.patient_pose_publisher.publish(all_poses_msg) |
There was a problem hiding this comment.
Wait, this is inside the for-loop. This and the following line (297) should be left indented a level to outside the for keypoints_ in keypoints: loop...
@cameron-a-johnson Wasn't this something that we looked at earlier in the summer? I thought we fixed this earlier. Was this publish inside the "maybe iterates once" for-loop intentional to only publish a message if there were keypoints? As this currently stands, messages are not being published for images that were processed, but no poses were estimated. It would not be "wrong" to publish a pose message for an image explicitly indicating there were no poses.
ros/angel_system_nodes/angel_system_nodes/latency_tracker/latency_tracker.py
Outdated
Show resolved
Hide resolved
Purg
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an MVP of a latency tracking node that can be run to review the latency of the pose estimation, object detection, and activity classification nodes.