improve dist.all_gather to support 0-size tensor all gather #77152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
/re-run all-failed |
SigureMo
reviewed
Dec 31, 2025
| def all_gather_object( | ||
| object_list: list[_T], obj: _T, group: Group = None | ||
| ) -> None: | ||
| def all_gather_object(object_list: list, obj, group: Group = None) -> None: |
| >>> dist.init_parallel_env() | ||
| >>> object_list = [] # type: ignore | ||
| >>> object_list = [None for _ in dist.get_world_size()] # type: ignore |
Member
There was a problem hiding this comment.
Suggested change
| >>> object_list = [None for _ in dist.get_world_size()] # type: ignore | |
| >>> object_list = [None for _ in range(dist.get_world_size())] # type: ignore |
明显的错误，类型提示都检查出来了
Member
|
改好了 |
SigureMo
previously approved these changes
Jan 1, 2026
Hz188
requested review from
XieYunshen,
gouzil,
risemeup1 and
zhangbo9674
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #77152 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 2
Lines ? 14
Branches ? 0
===========================================
Hits ? 14
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/re-run all-failed |
SigureMo
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Communication Library
PR Types
New features
Description
Now dist.all_gather supports 0-size tensor, not raise a bug.
pcard-73145