Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pydantic dependency #3715

Merged
merged 3 commits into from
Nov 4, 2024
Merged

fix pydantic dependency #3715

merged 3 commits into from
Nov 4, 2024

Conversation

Netrvin
Copy link
Contributor

@Netrvin Netrvin commented Mar 19, 2024

PR types

Bug fixes

PR changes

One of dependencies (pydantic)

Describe

When pydantic>=2.0, str cannot be directly None, it must be specified using Optional[str] or similar methods. If pydantic>=2.0 is used, it will lead to issues like the following:
In paddlespeech/server/restful/response.py, the TTSResponse's save_path: str = None will raise an error when save_path is None, thus causing an ErrorResponse to be returned.

pydantic>=2.0时,str不能为None
@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024

CLA assistant check
All committers have signed the CLA.

@mergify mergify bot added the Installation label Mar 19, 2024
setup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@zxcd zxcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxcd zxcd merged commit e41a879 into PaddlePaddle:develop Nov 4, 2024
4 of 5 checks passed
@luotao1
Copy link
Collaborator

luotao1 commented Nov 6, 2024

hi, @Netrvin

  • 非常感谢你对飞桨的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 [email protected],我们会邀请你加入~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants