-
Notifications
You must be signed in to change notification settings - Fork 2
Release #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sandornagy517
wants to merge
12
commits into
main
Choose a base branch
from
next
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release #69
+2,644
−1,119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: migrate backstage-plugin to new frontend system * update licence placeholder * changeset
) * feat: Migrate the relevant components of PagerDutySmallCard to Backstage UI * chore: Adjust unit tests after migrating EntityPagerDutySmallCard * chore: Update the imports of backstage ui css * style: Remove useless line breaks * chore: Fix failing unit tests * feat: Include backstage ui css in the app package * fix: Adjust styles for dark theme * docs: Add tests for dark theme to the PR checklist
* chore: remove remainings of old backend system * changeset
* feat: Migrate PagerDutyCard to backstage UI * chore: Add changeset * chore: Add changeset * chore: Get rid of wrong changeset
* Fix package.json metadata * Update .changeset/sad-teeth-show.md Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
* feat: Migrate PagerDutyPage to Backstage UI * chore: Undo entities.yaml * fix: Fix margins and use className instead of style
jhfgloria
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this version was tested in staging, I'm good with it.
* implement nfs best practices * apply pr recommendations * move backstage/ui back to dependencies * apply pr suggestions
Co-authored-by: Chris Micacchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release changes to main
Affected plugin
Type of change
Checklist
If this is a breaking change 👇
Acknowledgement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.