Skip to content

Advanced filtering #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Advanced filtering #18

wants to merge 4 commits into from

Conversation

ebikt
Copy link

@ebikt ebikt commented Sep 27, 2019

Advanced filtering, that lets user use any boolean expression of included or excluded users, teams or services.

First commit adds filtering by teams and fixes validation display in options. Other commits add advanced filtering.

@ebikt
Filter teams. Fix validation display.
e7f4a20 
 * Add support for pagerduty filter_ids[]= API filter.
 * Reset className="bad" of configuration input fields if
   they pass validation. Fixes bug, that input field wich
   was marked "bad" by validation, was not unmarked after
   user corrected its value.
@ebikt
Prepare for advanced filtering: pagination.
7a5804a
@ebikt
advanced-filter library
c656eaa
@ebikt
Advanced filtering.
ec191db
@ebikt
Copy link
Author

ebikt commented Nov 4, 2019 •
edited
Loading

I must admit that I have some weird memory/cpu leaks when this is enabled (main process of chromium goes wild, process of pagerduty is OK), the problem occurs when there are some (maybe many) triggered notifications to display, I did not managed yet to reproduce the problem, but it does not occur when the plugin is not enabled. However - when the problem occurs - it does not disappear by disabling the plugin. The problem might be in pagination of results as well as in original plugin before patching. Moreover the problem occurs only on one computer. Other computer with identical chromium version (both Linux) seems to be not affected. Maybe something in user profile is interferring.

Edit: now I hit the bug with the plugin completely disabled. Thus this is not an issue of this plugin nor this particular patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ebikt