Skip to content

Fix version flag to use git tag #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix version flag to use git tag #563

wants to merge 1 commit into from

Conversation

@phumpal
Copy link

@phumpal phumpal commented Sep 25, 2025

May be intentional but pd --version will always return 0.0.0. as version is a constant not a var.

cjgajard
cjgajard approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@cjgajard cjgajard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phumpal
Copy link
Author

phumpal commented Oct 17, 2025

@cjgajard anything you need from me to help move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjgajard cjgajard cjgajard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phumpal @cjgajard