Skip to content

[BUGFIX] Mass update script: Avoid passing in incident ids via query parameter, which can cause 414 errors #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BUGFIX] Mass update script: Avoid passing in incident ids via query parameter, which can cause 414 errors #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions mass_update_incidents/mass_update_incidents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,26 +58,27 @@ def mass_update_incidents(args):
PARAMETERS["date_range"] = "all"
print("Getting incidents of all time")

incident_ids_split = []
if args.incident_id:
PARAMETERS["incident_ids[]"] = args.incident_id.split(",")
if len(PARAMETERS["incident_ids[]"]) > MAX_INCIDENTS:
incident_ids_split = args.incident_id.split(",")
if len(incident_ids_split) > MAX_INCIDENTS:
raise ValueError(
f"You can only update a maximum of {MAX_INCIDENTS} incidents at a time. Received list of {len(PARAMETERS['incident_ids[]'])} incidents."
f"You can only update a maximum of {MAX_INCIDENTS} incidents at a time. Received list of {len(incident_ids_split)} incidents."
)
try:
print("Parameters: " + str(PARAMETERS))
script_start_time = time.time()

if args.incident_id:
if incident_ids_split:
if args.action == "resolve":
# If resolving incidents, we need to fetch the incident details for the alert counts
# Fetch incident bodies in bulk using the bulk update endpoint
print(
f"Fetching details for {len(PARAMETERS['incident_ids[]'])} incidents. Please be patient as this "
f"Fetching details for {len(incident_ids_split)} incidents. Please be patient as this "
"can take a while for large volumes..."
)
incident_references = []
for incident_id in PARAMETERS["incident_ids[]"]:
for incident_id in incident_ids_split:
incident_references.append(
{"id": incident_id, "type": "incident_reference"}
)
Expand All @@ -101,7 +102,7 @@ def mass_update_incidents(args):
# For acknowledging, we don't need to fetch incident details
incidents = [
{"id": incident_id, "type": "incident_reference"}
for incident_id in PARAMETERS["incident_ids[]"]
for incident_id in incident_ids_split
]
else:
print(
Expand Down