evm-contracts: Use forge-std instead of excerpted files#315
evm-contracts: Use forge-std instead of excerpted files#315
Conversation
forge install: forge-std v1.7.4
| [submodule "packages/contracts/evm-contracts/lib/forge-std"] | ||
| path = packages/contracts/evm-contracts/lib/forge-std | ||
| url = https://github.com/foundry-rs/forge-std |
There was a problem hiding this comment.
Is there no other way to do this? Submodules are always an absolute nightmare to work with
There was a problem hiding this comment.
This is the default way forge is installed, but... I guess we could replace the submodule with the files directly
There was a problem hiding this comment.
Is there any downside to the approach we had before where things are inline? I would prefer that over having to update every build tool going forward to support submodules
There was a problem hiding this comment.
I've ran into a few missing functions in the inline files, and I wasn't able to get them working just by adding them there. That's why I wanted to refactor into properly using forge-std. But in the end it is not a must-have, and if this would produce more problems than benefits, I'm fine with sunsetting this PR.
2 participants
No description provided.