Add Dockerfile for engine, batcher, and SDK images#353
Open
SpaceManiac wants to merge 2 commits intomasterfrom
Open
Add Dockerfile for engine, batcher, and SDK images#353SpaceManiac wants to merge 2 commits intomasterfrom
SpaceManiac wants to merge 2 commits intomasterfrom
Conversation
Contributor
Contributor
Author
|
Interesting. I see "gyp info using node@20.8.1 | linux | arm64" in the logs. I think since you're on an ARM Mac, it's building a Linux-for-arm image by default, while I'm on x86_64. We could set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



A bit of an experiment. The goal is to make it easier to version and deploy games, and to reduce accidental structural differences between dev, test, and production.
./docker-tag [tag]builds and tags the images with the given tag (ex:2.3.0) orlatestif not specified.The intended use of the images are:
paima-engineserves as a base for game backend images:paima-batchercan be run directly, supplying just the configuration:or included in a docker-compose file:
paima-sdkcan be used as aCOPYsource for a Docker build that needs a newer Node SDK than is on NPM:COPY --from=ghcr.io/paimastudios/paima-sdk:latest \ /node_modules/@paima \ node_modules/@paimaCaveats:
paima-engineimage is bigger than it needs to be because the binary includes the batcher, contracts, templates, so on. The image only really needs therunsubcommand.paima-sdkimage is a little goofy. An image of just free-hanging files is not really how Docker is meant to be used. But this seems like the easiest way to make compiled outputs of non-NPM-tagged versions available to downstream Docker builds.Thoughts?