get avail slots/timestamps from light client instead of rpc#406
Open
ecioppettini wants to merge 1 commit intomasterfrom
Open
get avail slots/timestamps from light client instead of rpc#406ecioppettini wants to merge 1 commit intomasterfrom
ecioppettini wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue availproject/avail-light#574 was addressed already, so we can update the code here, so that we remove the need for the extra rpc requests to the node (since the light client already did those requests before).
We may want to wait for the changes to be in a release before merging this though, but I have already tested with the latest main.
There is also an issue with some types, but I'm not sure yet if there is a way to fix it properly.