Conversation
e2e/client/batcher/main.ts
Outdated
| const isEnvTrue = (key: string) => ["true", "1", "yes", "y"].includes((getEnv(key) || (typeof process !== "undefined" ? process.env?.[key] : undefined) || "").toLowerCase()); | ||
| const midnight_enabled = !isEnvTrue("DISABLE_MIDNIGHT"); | ||
|
|
||
| // if (midnight_enabled) { |
There was a problem hiding this comment.
@Yiakman I commented this out, but we didn't have the chance to talk about it.
|
@Oak/oak
deno task -f <script>
@sylc/dkill
@std/log
patch.sh
build-tools/tui
|
I removed the dependency on Oak and used fastify as it's used elsehwere already
fe2e2d4 to
5bb178d
Compare
This PR migrates the entire codebase from
denotobun. I've organized the work in phases, working bottom-up in the dependency graph.Progress
package.jsonwith Bun workspace globs)packages/(effectstream-sdk,node-sdk,chains,build-tools)build-tools/tui, as @acedward has mentioned he may remove that entirelybun:test,run-tests.sh)e2e/(all 13 packages)Dockerfile,patch.sh)templates/npm. This must be done by @acedward)Important Decisions
Switching from
denotobunimplies several decision points, mostly regarding dependencies (some are only on JSR, which is harder to use with node, and some have strict deno requirements).@Oak/oakI removed the
@Oak/oakas it is only published onJSR. I decided to useFastifyinstead, as it was already used in the codebase and easy to replace.deno task -f <pkg> <script>For all workspace-scoped tasks, I've replaced the deno task logic with
bun run --filter <pkg> <script>. Recursive tasks (deno task -r) usebun run --filter '*'@sylc/dkillReplaced with
fkill, sincedkillwas JSR only.fkillwas the inspriation fordkill, so it was a simple change@std/logI made no decision about choosing a logger, since there are several options. Instead, I temporarily replaced the logger with
consolecalls. We should replace this with a proper logging library.patch.shpatch.sh` was used to patch certain dependencies. I assume they were mostly workarounds for Deno, but I kept them just in case. If it's no longer needed, we should remove the script.
build-tools/tuiI left this untouched, as it almost entirely depends on Deno and likely will require a complete rewrite. @acedward also mentioned removing it completely.