-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Installation.md added with few sample data (without Docker) #2696
feat: Installation.md added with few sample data (without Docker) #2696
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
a29ccfe
to
35bd28b
Compare
|
We will need a way for people to test the application by seeing what it can do. The loading of sample data via the setup script helps a lot. It also helps with the new contributors as they can get a better understanding of the features. We really need this. How can you facilitate this with the coding you are doing? |
Sure. I would love to apply the suggestions/modifications of @xoldd. And @palisadoes, can u please merge his PR #2698. I will be able to test the user authentication functionalities. Thank you :) |
It's merged |
According to me this way of seeding the database is bad and should not be carried out. Also, there are two types of database seeds, one is for dummy data that is only useful in development, testing environments etc., and one is for data that is common in all environments including the production. Creation of the administrator user associated to the Since there isn't a concept of service layer, for now the graphql resolvers are the single source of truth for most of the business logic. Database seeding will be done by triggering graphql mutation operations. Manually inserting data into the database like this is just gonna lead to duplication of business logic, inconsistency and seed data corruption. |
Thanks @xoldd . I think I should close this PR. The recent merge will change the script a bit ( |
We need a way to have demo data for prospective end users to evaluate the product. It has real value in helping us get adoption of an MVP. We will have to open this issue again when the postgres DB work is complete. |
What kind of change does this PR introduce?
Issue Number: #2666
Snapshots/Videos:
Migrations are applied:
Sample data loaded, graphql sdl file generated, server starts
Endpoint working
If relevant, did you update the documentation?
Added installation process in INSTALLATION.md file.
Summary
Local installation steps without docker with sample data loaded and working steps are defined in INSTALLATION.md file.
Other information
As I added some files which are crucial for sample data import, please git clone https://github.com/bandhan-majumder/talawa-api/tree/develop-postgres and the rest of the steps are as it is.
Have you read the contributing guide?
yes