-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing WAM broker authentication #78
base: main
Are you sure you want to change the base?
Conversation
Test Results130 tests 122 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit 69b2bee. ♻️ This comment has been updated with latest results. |
Your PR from a fork uncovered a bug in my testing workflow, which is now fixed (thanks! 👍). Let me know if you have any questions about the tests or such, most of them just check that proper docs and parameter tests are in place. There's also an approval step to run the code, since the last part of the workflow actually connects to a real identity in my tenant and gets a token as an integration test. |
Oh if you have integration tests for WAM / broker auth, you'll need to add the redirect uri for it. ms-appx-web://microsoft.aad.brokerplugin/{clientId} |
Only got integration tests for the workload identity federation from this repo atm, so that's fine right now. |
This closes #76 when merged |
Looking forward to the silent auth with -Broker 👌 FYI I have some basic logic to save credentials in the session, so there's already some "silent auth" built-in if you run an interactive flow such as |
Pull Request
Pull Request (PR) description
WAM Broker auth is cool. This PR should implement it correctly...
More details on PR to come, for now - beer awaits.
Task list