Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve handling of discriminators #1009

Merged
merged 3 commits into from
Oct 31, 2024
Merged

improve handling of discriminators #1009

merged 3 commits into from
Oct 31, 2024

Conversation

sserrata
Copy link
Member

Description

Long overdue improvements to how discriminator schemas are handled.

Important notes:

  • In the event that the discriminator property is defined at both the parent and sub schema levels, the plugin will attempt to merge the sub schema property into the parent

@sserrata sserrata added bug Something isn't working v4.0.0 v4.0.0 labels Oct 31, 2024
@sserrata sserrata self-assigned this Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

Size Change: -63 B (0%)

Total Size: 2.04 MB

Filename Size Change
demo/build/assets/css/styles.********.css 133 kB -33 B (-0.02%)
ℹ️ View Unchanged
Filename Size Change
demo/.docusaurus/codeTranslations.json 2 B 0 B
demo/.docusaurus/docusaurus.config.mjs 13.7 kB 0 B
demo/.docusaurus/globalData.json 38.6 kB 0 B
demo/.docusaurus/i18n.json 267 B 0 B
demo/.docusaurus/registry.js 56.9 kB 0 B
demo/.docusaurus/routes.js 52.6 kB 0 B
demo/.docusaurus/routesChunkNames.json 21.8 kB 0 B
demo/.docusaurus/site-metadata.json 1.23 kB 0 B
demo/build/assets/js/main.********.js 675 kB 0 B
demo/build/assets/js/runtime~main.********.js 14.6 kB 0 B
demo/build/index.html 94.5 kB 0 B
demo/build/petstore/add-pet/index.html 23.2 kB 0 B
demo/build/petstore/create-user/index.html 22.6 kB 0 B
demo/build/petstore/create-users-with-array-input/index.html 22.6 kB 0 B
demo/build/petstore/create-users-with-list-input/index.html 22.6 kB 0 B
demo/build/petstore/delete-order/index.html 22.6 kB 0 B
demo/build/petstore/delete-pet/index.html 22.7 kB 0 B
demo/build/petstore/delete-user/index.html 23 kB 0 B
demo/build/petstore/find-pets-by-status/index.html 23.4 kB 0 B
demo/build/petstore/find-pets-by-tags/index.html 24.1 kB 0 B
demo/build/petstore/get-inventory/index.html 21.9 kB 0 B
demo/build/petstore/get-order-by-id/index.html 22.9 kB 0 B
demo/build/petstore/get-pet-by-id/index.html 23.5 kB 0 B
demo/build/petstore/get-user-by-name/index.html 23 kB 0 B
demo/build/petstore/login-user/index.html 23.6 kB 0 B
demo/build/petstore/logout-user/index.html 22.3 kB 0 B
demo/build/petstore/new-pet/index.html 22.9 kB 0 B
demo/build/petstore/pet/index.html 24.6 kB 0 B
demo/build/petstore/place-order/index.html 22.1 kB 0 B
demo/build/petstore/schemas/apiresponse/index.html 24.1 kB 0 B
demo/build/petstore/schemas/cat/index.html 38.9 kB 0 B
demo/build/petstore/schemas/category/index.html 25.2 kB 0 B
demo/build/petstore/schemas/dog/index.html 39.3 kB 0 B
demo/build/petstore/schemas/honeybee/index.html 39.4 kB 0 B
demo/build/petstore/schemas/id/index.html 22.1 kB 0 B
demo/build/petstore/schemas/order/index.html 26.4 kB 0 B
demo/build/petstore/schemas/pet/index.html 38.8 kB -19 B (-0.05%)
demo/build/petstore/schemas/tag/index.html 23.5 kB 0 B
demo/build/petstore/schemas/user/index.html 47.6 kB -11 B (-0.02%)
demo/build/petstore/store/index.html 22.5 kB 0 B
demo/build/petstore/subscribe-to-the-store-events/index.html 29.2 kB 0 B
demo/build/petstore/swagger-petstore-yaml/index.html 29.6 kB 0 B
demo/build/petstore/update-pet-with-form/index.html 22.9 kB 0 B
demo/build/petstore/update-pet/index.html 23.3 kB 0 B
demo/build/petstore/update-user/index.html 22.9 kB 0 B
demo/build/petstore/upload-file/index.html 22.7 kB 0 B
demo/build/petstore/user/index.html 23.5 kB 0 B

compressed-size-action

Copy link

github-actions bot commented Oct 31, 2024

Visit the preview URL for this PR (updated for commit 273a27f):

https://docusaurus-openapi-36b86--pr1009-wj0t5zs1.web.app

(expires Sat, 30 Nov 2024 19:32:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@sserrata sserrata merged commit a42f4bf into main Oct 31, 2024
13 checks passed
@sserrata sserrata deleted the discriminator-support branch October 31, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v4.0.0 v4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant