fix(modules/lb_external): network_tier support

[jochristian]

Description

Fixes #58

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes if appropriate.
• All new and existing tests passed.

[danhusan]

+1

[horiagunica]

Hello @jochristian ! Thank you for adding this fix!

Would you mind changing your PR title to something lilke : fix(lb_external): lb external module network_tier support ?

That would fix the PR linting issue.

Thanks!

[horiagunica]

/idempotence paths="examples/multi_nic_common examples/panorama_standalone examples/standalone_vmseries_with_metadata_bootstrap examples/vmseries_ha examples/vpc_peering_common examples/vpc_peering_common_with_autoscale examples/vpc_peering_common_with_network_tags examples/vpc_peering_dedicated examples/vpc_peering_dedicated_with_autoscale" tf_version="1.7 1.8"

Testing job ID: 13032850629
Job result: SUCCESS

[michalbil]

@jochristian full support for the variable would require a bit more than adding this to forwarding rule resource, it also has to match the tier specified for IP address (it's not being explicitly set at the moment).

[jochristian]

hi @michalbil,

Yes you are correct. I forgot to add this to resource "google_compute_address" "this"
network_tier = var.network_tier

Sorry about this.
I haved pushed this change now.

[migara]

@pavelrn will review this PR