Skip to content

Conversation

@Pankraz76
Copy link
Owner

@Pankraz76 Pankraz76 commented Oct 13, 2025

> Task :lib:compileCompatKtLint0Dot50Dot0Java
/Users/vincent.potucek/IdeaProjects/spotless/lib/src/compatKtLint0Dot50Dot0/java/com/diffplug/spotless/glue/ktlint/compat/KtLintCompat0Dot50Dot0Adapter.java:58: warning: [ConstantNaming] Constant variables should adhere to the `UPPER_SNAKE_CASE` naming convention
        private static final Logger logger = LoggerFactory.getLogger(KtLintCompat0Dot50Dot0Adapter.class);
                                    ^
    (see https://error-prone.picnic.tech/bugpatterns/ConstantNaming)
  Did you mean 'private static final Logger LOGGER = LoggerFactory.getLogger(KtLintCompat0Dot50Dot0Adapter.class);'?
Refactoring changes were successfully applied to file:///Users/vincent.potucek/IdeaProjects/spotless/lib/src/compatKtLint0Dot50Dot0/java/com/diffplug/spotless/glue/ktlint/compat/KtLintCompat0Dot50Dot0Adapter.java, please check the refactored code and recompile.
1 warning


why its not working on junit?

Despite being able to fix other checks with this setup:

@rickie

)
errorproneArgs.addAll(
"-XepPatchLocation:IN_PLACE",
"-XepPatchChecks:LexicographicalAnnotationListing"
Copy link

@rickie rickie Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this line does work and auto applies changes, but the line below doesn't make any changes? Do you see an error or not?

Do you have twice the -XepPatchChecks when enabling the rule or not?

@rickie
Copy link

rickie commented Oct 13, 2025

Did you compare both of the setups? So https://github.com/Pankraz76/spotless/pull/4/files and the JUnit one? If it does work for Spotless there is probably something misconfigured for JUnit? That would be my guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants