Skip to content

Conversation

@Pankraz76
Copy link
Owner

@Pankraz76 Pankraz76 commented Oct 6, 2025

 Did you mean 'requireNonNull(version);'?
/Users/vincent.potucek/IdeaProjects/spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/ShellExtension.java:46: Note: [StaticImport] Identifier should be statically imported
		Objects.requireNonNull(version);
		       ^
    (see https://error-prone.picnic.tech/bugpatterns/StaticImport)
  Did you mean 'requireNonNull(version);'?
/Users/vincent.potucek/IdeaProjects/spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/PomExtension.java:49: Note: [StaticImport] Identifier should be statically imported
		Objects.requireNonNull(version);
		       ^
    (see https://error-prone.picnic.tech/bugpatterns/StaticImport)
  Did you mean 'requireNonNull(version);'?
/Users/vincent.potucek/IdeaProjects/spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/PomExtension.java:62: Note: [StaticImport] Identifier should be statically imported
			cfg.version = Objects.requireNonNull(version);
			                     ^
    (see https://error-prone.picnic.tech/bugpatterns/StaticImport)
  Did you mean 'cfg.version = requireNonNull(version);'?
Refactoring changes were successfully applied to file:///Users/vincent.potucek/IdeaProjects/spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/BaseKotlinExtension.java, please check the refactored code and recompile.
Refactoring changes were successfully applied to file:///Users/vincent.potucek/IdeaProjects/spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/PluginGradlePreconditions.java, please check the refactored code and recompile.

on corruption:

				         ^
    (see https://error-prone.picnic.tech/refasterrules/StreamRules#StreamOfArray)
  Did you mean 'Arrays.stream(additionalFileContents));'?
/Users/vincent.potucek/IdeaProjects/spotless/lib/src/main/java/com/diffplug/spotless/protobuf/BufStep.java:108: Note: [Refaster Rule] ImmutableListRules.ImmutableListOf3: Refactoring opportunity
			List<String> args = List.of(exeAbsPath, "format", file.getAbsolutePath());
			                           ^
    (see https://error-prone.picnic.tech/refasterrules/ImmutableListRules#ImmutableListOf3)
  Did you mean 'List<String> args = ImmutableList.of(exeAbsPath, "format", file.getAbsolutePath());'?
/Users/vincent.potucek/IdeaProjects/spotless/lib/src/main/java/com/diffplug/spotless/sql/dbeaver/SQLTokensParser.java:189: Note: [RedundantStringConversion] Avoid redundant string conversions when possible
				return new FormatterToken(TokenType.COMMAND, word + s.toString(), start_pos);
				                                                  ^
    (see https://error-prone.picnic.tech/bugpatterns/RedundantStringConversion)
  Did you mean 'return new FormatterToken(TokenType.COMMAND, word + s, start_pos);'?
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
100 warnings

> Task :lib:compileJava FAILED

[Incubating] Problems report is available at: file:///Users/vincent.potucek/IdeaProjects/spotless/build/reports/problems/problems-report.html
21 actionable tasks: 21 executed

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':lib:compileJava'.
> Compilation failed; see the compiler output below.
  /Users/vincent.potucek/IdeaProjects/spotless/lib/src/main/java/com/diffplug/spotless/java/ModuleHelper.java:37: warning: Unsafe is internal proprietary API and may be removed in a future release
  import sun.misc.Unsafe;
                 ^
  1 error
  100 warnings

BUILD FAILED in 24s
Configuration cache entry stored.
14:34:35: Execution finished 'clean assemble'.

relates to:

@Pankraz76 Pankraz76 force-pushed the error-prone-SanityCheck branch from a2baae8 to a49f295 Compare October 6, 2025 13:03
@Pankraz76 Pankraz76 force-pushed the error-prone-SanityCheck branch from a49f295 to 06e1ca9 Compare October 6, 2025 13:50
@Pankraz76 Pankraz76 marked this pull request as ready for review October 6, 2025 13:50
@Pankraz76 Pankraz76 merged commit 14ae030 into main Oct 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants