ios17 komga download fix #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After doing some testing for some reason the authorization section of the header never gets set if you just set the 'authorizaton' part of the headers. Resesting 'headers' to a new Record seems to resolve this.
|
Works for me too, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing some testing for whatever reason the authorization section of the header never gets changed if you just do
request.headers.authorization = getAuthorizationString(this.stateManager), causing the authorization token to never be set seemingly specifically when downloading things, at least on my ipad. Settingrequest.headersto a new Record seems to resolve this, for whatever reason.Notably this fixes Paperback-iOS/app#665 at least for me.