Add icons for Crystal source files#3762
Closed
BigBoyBarney wants to merge 1 commit intoPapirusDevelopmentTeam:masterfrom
BigBoyBarney:master
Closed
Add icons for Crystal source files#3762BigBoyBarney wants to merge 1 commit intoPapirusDevelopmentTeam:masterfrom BigBoyBarney:master
BigBoyBarney wants to merge 1 commit intoPapirusDevelopmentTeam:masterfrom
BigBoyBarney:master
Conversation
Member
|
it looks good! can you please change the elements to use Papirus colours - #e4e4e4 for white, #4f4f4f for dark grey (you can use a lighter grey, but please not in rgb format). also, the inner triangle could be better aligned to the pixel grid. for a bit of streamlining, it would be better if the elements are not grouped. |
Author
|
Thank you for looking at it! I'll take a look at the triangle, but it's a bit tough without changing the shape of the logo too much. Regarding the colours, the template itself was <svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" version="1.1">
<path style="opacity:0.2" d="M 6.375,3 C 5.61325,3 5,3.6244 5,4.4 V 29.6 C 5,30.37504 5.61325,31 6.375,31 h 19.25 C 26.3862,31 27,30.37504 27,29.6 V 12 L 20,10 18,3 Z"/>
<path style="fill:#e4e4e4" d="M 6.375,2 C 5.61325,2 5,2.6244 5,3.4 V 28.6 C 5,29.37504 5.61325,30 6.375,30 h 19.25 C 26.3862,30 27,29.37504 27,28.6 V 11 L 20,9 18,2 Z"/>
<path style="opacity:0.2" d="M 27,12 18,3 v 7.59375 C 18,11.373375 18.62775,12 19.40625,12 Z"/>
<path style="fill:#fafafa" d="M 27,11 18,2 V 9.59375 C 18,10.373375 18.62775,11 19.40625,11 Z"/>
<path style="opacity:0.2;fill:#ffffff" d="M 6.375,2 C 5.61325,2 5,2.6247906 5,3.4003906 v 1 C 5,3.6247906 5.61325,3 6.375,3 H 18 V 2 Z"/>
</svg> |
SmartFinn
pushed a commit
that referenced
this pull request
May 1, 2025
Member
|
Fixed and merged in 7a20c35. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first icon-set, so any feedback is very welcome!!
Thanks!