Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Mattermost plugin module federation #10517

Merged
merged 19 commits into from
Dec 17, 2024
Merged

chore: Mattermost plugin module federation #10517

merged 19 commits into from
Dec 17, 2024

Conversation

Dschoordsch
Copy link
Contributor

Description

Fixes/Partially Fixes #[issue number]
[Please include a summary of the changes and the related issue]

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Scenario A

    • Step 1
    • Step 2...

  • Scenario B

    • Step 1
    • Step 2....

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@Dschoordsch Dschoordsch changed the title Chore/mattermost plugin module federation chore: mattermost plugin module federation Nov 25, 2024
@Dschoordsch Dschoordsch changed the title chore: mattermost plugin module federation chore: Mattermost plugin module federation Nov 25, 2024
@Dschoordsch Dschoordsch force-pushed the chore/mattermostPluginModuleFederation branch from ee367d3 to 66b07cb Compare December 11, 2024 10:54
@github-actions github-actions bot added size/xl and removed size/m labels Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@Dschoordsch Dschoordsch marked this pull request as ready for review December 16, 2024 12:32
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@Dschoordsch
Update axios to resolve CWE
15d37d4 
Also removed analytics-node because it is unused.
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@Dschoordsch
Serve mattermost components from webserver
fea9ac5 
Prefix the components with `mattermost-plugin` to avoid potential
conflicts.
@Dschoordsch
Rename plugin entry
ddd0b0d
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@Dschoordsch
Copy link
Contributor Author

There are still some minor issues with the updated version, but I want to merge this so the plugin itself can be updated and then we can hopefully just run with it.

@Dschoordsch Dschoordsch merged commit 79fd8a2 into master Dec 17, 2024
7 checks passed
@Dschoordsch Dschoordsch deleted the chore/mattermostPluginModuleFederation branch December 17, 2024 17:08
@parabol-release-bot parabol-release-bot bot mentioned this pull request Dec 17, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dschoordsch