Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom RQ job class capability with --job-class #392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gord1anknot
Copy link

Description

Hello! This PR adds the job class capability to rq-dashboard. Please let me know what additional sort of unit tests you'd expect to see; I've formatted with isort and black and ensured pytest and flake8 are passing.

For my company's internal implementation of RQ we use a custom job class as described here:

https://python-rq.org/docs/workers/#worker-arguments

The way the RQ API works, you essentially need to pass this every time you construct an object (there's no global variable for this).

Also, not every function in RQ is capable of respecting this setting. In particular, rq-dashboard uses requeue_job which is incapable of respecting the setting so I replaced it's usage.

This PR would add the capability to specify this according to what I perceive to be the pattern in the repo. Internally, RQ accepts this parameter as a string - rq-dashboard would too, if this is accepted, which I think is the simplest way to specify it for the operator.

@cjlapao
Copy link
Collaborator

cjlapao commented Jun 19, 2023

@gord1anknot could you please review the conflicts? after that I can run the testing again and merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants