Parcels v4 FieldSet design documentation #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeckoTheGecko
requested review from
danliba,
erikvansebille,
fluidnumerics-joe and
willirath
erikvansebille
approved these changes
Feb 11, 2025
Contributor
|
Hey gents, I've pushed up a suggestion for concretizing the |
VeckoTheGecko
commented
Feb 11, 2025
Contributor
|
The last two commits resolve the conversations above, I believe . @erikvansebille |
erikvansebille
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR created a hub in the docs for v4 design choices.
The first page for this is the FieldSet design documentation as discussed.
Are there any parts of this API that we need to further explore now, or is that more on the implementation side when the code is actually written?
Fixes #1848
See docs (v4 hub)
Interactive Mermaid Editor with initial design