Removing JIT from tests #1853
Merged
Removing JIT from tests #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
VeckoTheGecko
approved these changes
Feb 14, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good to me. Just confirming that the deleted tests in test_fieldset.py were specific to JIT?
| da = xr.open_dataset(str(tmp_zarrfile).replace(".zarr", "_0005U.nc")) | ||
| assert np.allclose(fieldset.U.data, da["U"].values, atol=1.0) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
I assume that test_from_netcdf_memory_containment() was quite specific to JIT?
Member
Author
There was a problem hiding this comment.
These tests were mostly about the field-chunking; but that will go too in v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, which is part of v4-development, removes the tests for JIT-mode from the unit tests, the examples and the tutorials. This is the first step to removing JIT altogether from Parcels in v4