Remove cstruct objects and remove c-contiguous requirement #1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeckoTheGecko
changed the title
erikvansebille
approved these changes
Feb 24, 2025
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Well spotted; I should have removed all this when I removed JIT-support in #1847. Thanks for doing this now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more JIT related cleanup
Remove c-contiguous array requirements for Grid class attributes (afaik this is directly related to JIT, and the assumed memory layout)
remove
cstructobjects and other ctypes structuresRemove unused
Field._c_data_chunksRemove some unused references to c_int
Chose the correct base branch (
mainfor v3 changes,v4-devfor v4 changes)xref Remove JIT #1847