Use datetime64 natively for particle time throughout codebase (and drop TimeConverter and time_origin) #1876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And first attempt at implementing native numpy.datetime64 support for time
Member
Author
|
This has now been implemented in #2079 |
github-project-automation
bot
moved this from In progress
to Done
in Parcels v4 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
TimeConverterClass andtime_originvariable for Fields (as suggested in #1844). It als implements native use ofnumpy.datetime64andnumpy.timedelta64in the particle execution.mainfor v3 changes,v4-devfor v4 changes)