Remove time_periodic
#1880
Merged
Remove time_periodic
#1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With removal of time_periodic in Field, periods is always 0 which simplifies compute_time_chunk
VeckoTheGecko
changed the title
time_periodic from codebasetime_periodic
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Looks good! Just two small comments
VeckoTheGecko
force-pushed
the
v/time-periodic
branch
from
f29034e to
5b5203f
Compare
erikvansebille
approved these changes
Feb 25, 2025
Co-authored-by: Erik van Sebille <[email protected]>
erikvansebille
added a commit
that referenced
this pull request
Feb 27, 2025
This PR continues the removal of removing time_periodic in #1880
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
update notebook markdown cell (didn't rerun, they will be rerun down the line anyway)
remove
Field.time_periodic, corresponding method arguments, docstringsremove
time_periodicmethod arguments fromFieldSet, update docstringsFlag tests explicitly testing time periodic functionality with
v4removeandxfailUpdate other tests
remove
Grid.periods(and update_computeTimeChunk)Chose the correct base branch (
mainfor v3 changes,v4-devfor v4 changes)xref Create an inventory of features to drop in v4 #1844