Removing explicit field chunking #1892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this will be handled by xarray in v4
Contributor
Yes, I think this is correct. The chunks parameter can be specified when reading in with Xarray (Parallel Computing with Dask | Chunking and performance) |
VeckoTheGecko
approved these changes
Feb 27, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good. I want to push some edits to this, @erikvansebille are you still actively working on this PR? If not, I can PR into this PR
Member
Author
I just pushed 38770d1, done for now |
Contributor
This covered most of the stuff I had in mind. Pushed a small edit, but otherwise this looks good to merge |
1 task
github-project-automation
bot
moved this from In progress
to Done
in Parcels v4 release
github-project-automation
bot
moved this from In progress
to Done
in Parcels development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the support for
chunkingin theFieldSet. As we transition to native xarray/dask to provide Field data, the Parcels implementation is not needed anymore?mainfor v3 changes,v4-devfor v4 changes)