Reworking kernel internels #2123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing base class to make refactoring easier. Interaction kernel support will be implmented at a later date
Did not update the notebooks.
Looks like the implementation doesn't work (old code from v3) and also isn't very maintainable. This was to support seeing if kernels had changed, and then recompiling them so that pset.execute wasn't slow. This can be implemented in v4 in a maintainable way - but this isn't a priority for now.
- Update Kernel init to take list of functions - Remove AST component of Kernels - Update merge to combine list of kernel functions - Add tests
Functionality is no longer desired
Flagged by test_pset_stop_simulation
VeckoTheGecko
force-pushed
the
2107-split-kernels
branch
from
5ecd7b9 to
5cbdc2d
Compare
for more information, see https://pre-commit.ci
VeckoTheGecko
requested review from
erikvansebille
and removed request for
erikvansebille
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Great clean-up effort!
erikvansebille
approved these changes
Jul 30, 2025
erikvansebille
added a commit
that referenced
this pull request
Aug 1, 2025
This fixes the failing RK45 test introduced in #2123
This was referenced Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a significant changeset as outlined in #2107 . As there are a lot of related parts, its a bit of a larger PR.
This PR looks to:
Changes:
particle.delete()(this is a breaking change)particle_dlon,particle_dlat,particle_ddepth(this is a breaking change)Kernel.funccode,Kernel.py_ast,Kernel.funcvarsfrom internals and initKernel.funcnamefrom initFuture work:
_positionupdate_kernels_addedstate variable (easier to do this another way)Breaking changes are recorded in
v3to4-breaking-changes.mdso that we have an overview during development (the purpose of this doc currently is only for breaking changes we intend to propogate to v4 of Parcels so that we can use this as a basis for the migration guide. For things that are currently breaking changes or things where its uncertain where we'll land, I propose we use the issue tracker instead).I have one test failure in this branch on
tests/v4/test_advection.py::test_moving_eddy[RK45-1e-05]- still need to investigate.